Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Aug 30, 2023

Fixes #154.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.3.26 ready to publish
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/firehose/lib/firehose.dart 💔 Not covered
pkgs/firehose/lib/src/health/coverage.dart 💚 41 % ⬆️ 2 %
pkgs/firehose/lib/src/repo.dart 💚 87 % ⬆️ 1 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.3.26 ready to publish firehose-v0.3.26
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballing this it looks good.

I don't believe we can easily verify this fix in our use case because the GitHub workflows rely on a published (globally activated) version of this package:

run: dart pub global run firehose --validate

@mosuem mosuem merged commit 8fa89c6 into main Aug 31, 2023
@mosuem mosuem deleted the addFlutterPublishSupport branch August 31, 2023 06:23
@mosuem mosuem mentioned this pull request Aug 31, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make dart pub global run firehose --validate work with Flutter projects to support autopublishing

3 participants