Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Aug 31, 2023

Fix the Flutter support implemented in #155 by setting up Flutter if requested.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.3.27 ready to publish
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@mosuem mosuem requested a review from HosseinYousefi August 31, 2023 10:08
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.3.27 ready to publish firehose-v0.3.27
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mosuem!

@HosseinYousefi HosseinYousefi merged commit 54d1628 into main Aug 31, 2023
@HosseinYousefi HosseinYousefi deleted the fixFlutterFirehose branch August 31, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:firehose type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants