Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Sep 11, 2023

Maybe this helps with the http problems.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

PR Health

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 1.0.0 already published at pub.dev
package:firehose 0.3.27 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ❗

Details
Package Changed Files
package:firehose pkgs/firehose/lib/src/health/coverage.dart
pkgs/firehose/lib/src/health/health.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check

Coverage ⚠️

Details
File Coverage
pkgs/firehose/lib/src/health/coverage.dart 💚 41 %
pkgs/firehose/lib/src/health/health.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 11, 2023
@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Sep 11, 2023
@mosuem mosuem merged commit e96fbdb into main Sep 12, 2023
@mosuem mosuem deleted the fixHealthIssues branch September 12, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants