Skip to content

Reuse Github instances in health workflow. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosuem merged 1 commit into from
Sep 12, 2023
Merged

Reuse Github instances in health workflow. #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/firehose/lib/src/health/coverage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ class Coverage {

Coverage(this.coverageWeb);

Future<CoverageResult> compareCoverages() async {
var files = await Github().listFilesForPR();
Future<CoverageResult> compareCoverages(Github github) async {
var files = await github.listFilesForPR();
var basePath = '../base_repo/';

return compareCoveragesFor(files, basePath);
Expand Down
4 changes: 2 additions & 2 deletions pkgs/firehose/lib/src/health/health.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
}

Future<HealthCheckResult> licenseCheck(Github github) async {
var files = await Github().listFilesForPR();
var files = await github.listFilesForPR();
var allFilePaths = await getFilesWithoutLicenses(Directory.current);

var groupedPaths = allFilePaths
Expand Down Expand Up @@ -159,7 +159,7 @@ Changes to files need to be [accounted for](https://github.com/dart-lang/ecosyst
Github github,
bool coverageWeb,
) async {
var coverage = await Coverage(coverageWeb).compareCoverages();
var coverage = await Coverage(coverageWeb).compareCoverages(github);

var markdownResult = '''
| File | Coverage |
Expand Down