Skip to content

Conversation

@RTodorov
Copy link
Contributor

@RTodorov RTodorov commented Sep 8, 2021

Fixes #463

@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 8, 2021
@RTodorov
Copy link
Contributor Author

RTodorov commented Sep 8, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 8, 2021
@kevmoo kevmoo requested a review from srawlins September 8, 2021 00:22
b.body.add(Code('// ignore_for_file: prefer_const_constructors\n'));
// The code_builder `asA` API unconditionally adds defensive parentheses.
b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n\n'));
b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An aside for @srawlins – wonder if we should pull these ignores into a constant and DRY up this logic a bit...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like having a comment for why each one might be needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could go in the constant definition, right?

Copy link
Member

@srawlins srawlins Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it could.

I do hope to eliminate all of these and replace with dart-lang/sdk#46957.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, could we perhaps get this one merged? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the support just landed for "all lints", but it will be introduced in Dart 2.15, which is many moons from now.

@srawlins srawlins merged commit 95779cf into dart-lang:master Sep 10, 2021
@RTodorov RTodorov deleted the patch-1 branch September 10, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ignore_for_file: camel_case_types

3 participants