-
Notifications
You must be signed in to change notification settings - Fork 172
Add ignore_for_file: camel_case_types to generated file #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
| b.body.add(Code('// ignore_for_file: prefer_const_constructors\n')); | ||
| // The code_builder `asA` API unconditionally adds defensive parentheses. | ||
| b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n\n')); | ||
| b.body.add(Code('// ignore_for_file: unnecessary_parenthesis\n')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An aside for @srawlins – wonder if we should pull these ignores into a constant and DRY up this logic a bit...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like having a comment for why each one might be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could go in the constant definition, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it could.
I do hope to eliminate all of these and replace with dart-lang/sdk#46957.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, could we perhaps get this one merged? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the support just landed for "all lints", but it will be introduced in Dart 2.15, which is many moons from now.
Fixes #463