search.getElementDeclerations doesn't include class constructors

[DanTup]

I've moved my document symbol provider over to the new search.getElementDeclerations API but it seems to be missing constructors that aren't named (named constructors appear fine).

@scheglov

[bwilkerson]

Any preference for what the label ought to look like? I'd generally assume "MyClass() MyClass", but that seems a bit redundant and inconsistent with "named() MyClass". We could remove the inconsistency if named constructors also duplicated the class name, but that only increases the redundancy.

[DanTup]

@bwilkerson I struggled to come up with a good plan and hoped you'd have an idea! 😁

All of the options I can come up with seem wonky for one reason or another:

Option 1

• () and MyClass
• named() and MyClass

Option 2

• MyClass() and ""
• MyClass.named() and ""

Option 3

• MyClass() and MyClass
• MyClass.named() and MyClass

TypeScript is a lame one to copy here, as it doesn't show parens/args for anything. What does your current IDE do (assuming it has some sort of symbol list or outline view)?

[DanTup]

(FWIW, I think maybe having MyClass duplicated in the label and containerName might be the least weird)

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/46004

We will provide empty name, you can present it in the way you think is the best for users :-)

FWIW, IntelliJ includes the class name in names of constructors.

[DanTup]

Great, thanks!

[bwilkerson]

Is there still work to be done here, or can this be closed?

[DanTup]

Yep, this is all done 👍