Code completion doesn't suggest from dev_dependencies, but manually referencing classes does not generate errors/warnings

[DanTup]

I had reports of code completion missing some classes that were valid in the current scope, for example Provider here:

It turned out that the provider package was listed in dev_dependencies and it seems like these should not be used in the lib folder:

sdk/pkg/analyzer/lib/src/services/available_declarations.dart

Lines 176 to 178 in 5b18fa0

	/// With `Pub`, files below the `pubspec.yaml` file can access libraries
	/// of packages listed as `dependencies`, and files in the `test` directory
	/// can in addition access libraries of packages listed as `dev_dependencies`.

However, typing these classes manually does not generate any warnings/errors, and as far as I can tell there is no lint for this.

If it's not valid to import dev_dependencies into lib, it seems like an error/warning should be generated? If it is, then it seems like they should be included in completion?

[bwilkerson]

This is a long standing issue (as old as pub). The problem is that when pub generates the package_config.json file it only generates one file that includes the transitive closure of both dev and non-dev dependencies. It really ought to be generating two files, one for use in lib and one for use outside lib.

Baring such a change, yes, it would be good for the analyzer to add

• a hint for imports of packages that are in the dev dependencies in libraries inside lib and
• a lint for imports of packages that are not listed in the pubspec.yaml file (indirect dependencies).

I think there's a separate issue for the second, so we can use this issue for the first.

[DanTup]

If I understand correctly, I think dart-archive/linter#2659 / https://dart-lang.github.io/linter/lints/depend_on_referenced_packages.html addresses both of the descriptions above?

[DanTup]

@bwilkerson does the lint above cover everything desired here? If so, I think this can be closed.

[bwilkerson]

Yes, I think it does.