LSP: Support Inline Value Request textDocument/inlineValue

[sebthom]

Hi,
it would be great if the Dart Language Server could support Inline Value Request: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_inlineValue

[dart-github-bot]

Summary: User requests Dart LSP support for the textDocument/inlineValue feature, enabling inline value display in editors. This improves developer experience.

[bwilkerson]

@DanTup

[DanTup]

I looked at trying to implement this in the VS Code extension in the past (Dart-Code/Dart-Code#1163) but it had some quirks in VS Code that I didn't like (see microsoft/vscode#60150 which was closed as out of scope). Some time has passed (and it's since been added to LSP) so it would be worth trying out again because things may have changed.

@sebthom is it VS Code or another editor you're interested in seeing the results in? Is it local variables and parameters you're expecting to see values for, or something more?

[sebthom]

@DanTup thanks for your prompt response! I want to leverage this in the Eclipse IDE but all the VSCode users will obviously also benefit from it. I am interested in local and parameter values during step debugging, i.e. InlineValueText. I don't think we need InlineValueVariableLookup or InlineValueEvaluatableExpression

[DanTup]

I don't think we need InlineValueVariableLookup or InlineValueEvaluatableExpression

I actually thought the opposite, so I wonder if I've misunderstood something. The only other option here is "text" which means the LSP server would have to provide the literal values to show - however the LSP server has no connection to the debug session, so it cannot see the values of expressions at runtime.

So my understanding is that we would have to return InlineValueEvaluatableExpression and/or InlineValueVariableLookups from the LSP server to provide the expression (or variable name) for any given range, which the editor would then send to the debug adapter for evaluation.

[sebthom]

Yeah, you are right. I am new to the inlineValue feature myself. So the LS provides the expressions and lookups and then I need somehow get the values from the DAP session. The LS could theoretically provide inlineText for constants.

[DanTup]

and then I need somehow get the values from the DAP session

I presume by "I" you mean as an author or LSP/DAP support (and not a user)? But yeah, there needs to be some interaction between LSP and DAP here.

The LS could theoretically provide inlineText for constants.

Yep! :)

[sebthom]

Yes with "I" I meant me as developer of the LSP/DAP integration in Eclipse