Duplicated fixes if 2 imports are unused

[gryznar]

1. Prepare
   

2. Right click on any warning

Result

• fixes are duplicated
• "unused" and "shown" are not properly separated

[srawlins]

CC @FMorschel

[gryznar]

As a side note: it will be very handy to automatically remove all unused / duplicated imports at once. Currently, every case requires manual fix. IntelliJ has an option to optimize imports while reformatting, but this is verry buggy

[FMorschel]

it will be very handy to automatically remove all unused / duplicated imports at once

IIRC, Organize Imports should do that, but I also agree we should probably review this fix.

[gryznar]

I've checked organize imports and it does not handle duplicated imports if I remember correctly. Also it fixes once at a time

[gryznar]

Btw, comming from Python, Dart with its analyzer, builtin linter and formatter is totally great IMO. Thank you for your great work!

[FMorschel]

I've just tested:

import 'dart:math' show max, min, Random;

Random? r;

In Dart 3.8.0-edge.151edd1aabe115e8b204918f038a93e7ff5b63b2 (2025-03-17) and I can't see this neither in VS Code or IntelliJ.

Can you share a repro and the version you found this bug? On this version, I can also use Organize Imports to fix both diagnostics at once.

[gryznar]

Ah, so this was fixed recently. Sorry for confusing. I am using latest stable: 3.7.2

[FMorschel]

It's fine! Always better to notify than to have bugs. Is there anything else this issue should address? Or can we close it? If there is nothing else feel free to close this. I'm not from the team so I can't do that.

P.S.: Fixes/assists can always be tested on main at dartpad.dev if you change the channel below on the page.

P.S. 2: I found this:

• Analyzer: "Organize imports" doesn't remove unused "show" directives. #36737

[gryznar]

Yet another case come into my mind, but this may be not possible to achieve. IntelliJ has "Optimize imports" flag (available under "alt+shift+l") and if it could be joined with "organize imports", it will be perfect. But I am aware that it can be outside control.

The issue may be closed. Thank you once again and sorry for this whole churn