FFI test failures on ASAN Mac

[rmacnak-google]

Many tests, including

ffi/address_of_array_generated_test/0 Crash (expected Pass)
ffi/address_of_array_generated_test/1 Crash (expected Pass)
ffi/address_of_array_generated_test/2 Crash (expected Pass)
ffi/address_of_array_generated_test/3 Crash (expected Pass)
ffi/address_of_cast_test Crash (expected Pass)
ffi/address_of_struct_generated_test/0 Crash (expected Pass)
ffi/address_of_struct_generated_test/1 Crash (expected Pass)
ffi/address_of_struct_generated_test/2 Crash (expected Pass)
ffi/address_of_struct_generated_test/3 Crash (expected Pass)
ffi/address_of_test/0 Crash (expected Pass)
ffi/address_of_test/1 Crash (expected Pass)
ffi/address_of_test/2 Crash (expected Pass)
ffi/address_of_test/3 Crash (expected Pass)
ffi/address_of_typeddata_generated_test/0 Crash (expected Pass)
ffi/address_of_typeddata_generated_test/1 Crash (expected Pass)
ffi/address_of_typeddata_generated_test/2 Crash (expected Pass)
ffi/address_of_typeddata_generated_test/3 Crash (expected Pass)
ffi/aliasing_test Crash (expected Pass)
ffi/data_test Crash (expected Pass)
ffi/function_callbacks_structs_by_value_generated_test/0 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_generated_test/1 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_generated_test/2 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_generated_test/3 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_native_callable_generated_test/0 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_native_callable_generated_test/1 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_native_callable_generated_test/2 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_native_callable_generated_test/3 Crash (expected Pass)
ffi/function_callbacks_structs_by_value_test Crash (expected Pass)
...

are failing on configurations

vm-aot-asan-mac-release-x64
vm-asan-mac-release-x64
vm-asan-win-release-x64

with stacks like

===== CRASH =====
si_signo=Segmentation fault: 11(11), si_code=SEGV_MAPERR(1), si_addr=0x1165f6000
version=3.9.0-edge (main) (Unknown timestamp) on "macos_x64"
pid=32161, thread=16131, isolate_group=main(0x61f000008c80), isolate=main(0x618000000c80)
os=macos, arch=x64, comp=no, sim=no
isolate_instructions=1135ae0c0, vm_instructions=1135a8000
fp=70000d0faaa0, sp=70000d0faaa0, pc=11022e5b4
  pc 0x000000011022e5b4 fp 0x000070000d0faaa0 std::__2::collate<wchar_t>::do_hash(wchar_t const*, wchar_t const*) const+0x24
  pc 0x000000011023e091 fp 0x000070000d0fab40 std::__2::__num_put<char>::__widen_and_group_int(char*, char*, char*, char*, char*&, char*&, std::__2::locale const&)+0x121
  pc 0x000000011023abc3 fp 0x000070000d0fac00 std::__2::ostreambuf_iterator<char, std::__2::char_traits<char>> std::__2::num_put<char, std::__2::ostreambuf_iterator<char, std::__2::char_traits<char>>>::__do_put_integral[abi:ne210000]<long>(std::__2::ostreambuf_iterator<char, std::__2::char_traits<char>>, std::__2::ios_base&, char, long) const+0x403
  pc 0x000000011026f37c fp 0x000070000d0fac60 std::__2::basic_ostream<char, std::__2::char_traits<char>>& std::__2::basic_ostream<char, std::__2::char_traits<char>>::__put_num_integer_promote[abi:ne210000]<int>(int)+0x12c
  pc 0x00000001164dd169 fp 0x000070000d0facb0 TakeInt8PointerMany+0x69
  pc 0x000000011365bdb7 fp 0x000070000d0fae60 Unknown symbol
  pc 0x00000001136620a8 fp 0x000070000d0faf98 Unknown symbol
  pc 0x000000011365f658 fp 0x000070000d0fafb0 Unknown symbol
  pc 0x0000000113662120 fp 0x000070000d0fafc0 Unknown symbol
  pc 0x0000000113662d6b fp 0x000070000d0fb038 Unknown symbol
  pc 0x00000001135dd606 fp 0x000070000d0fb070 Unknown symbol
  pc 0x000000011366307d fp 0x000070000d0fb0f0 Unknown symbol
  pc 0x00000001136059af fp 0x000070000d0fb118 Unknown symbol
  pc 0x00000001135ac3cd fp 0x000070000d0fb190 Unknown symbol
  pc 0x00000001104a6cfa fp 0x000070000d0fb2b0 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&)+0x39a
  pc 0x00000001104ab269 fp 0x000070000d0fb310 dart::DartLibraryCalls::HandleMessage(long long, dart::Instance const&)+0x2b9
  pc 0x00000001104ef7a6 fp 0x000070000d0fba70 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message>>)+0x876
  pc 0x000000011050e498 fp 0x000070000d0fbbb0 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)+0x408
  pc 0x000000011050ee6a fp 0x000070000d0fbc30 dart::MessageHandler::TaskCallback()+0x53a
  pc 0x000000011075fd20 fp 0x000070000d0fbdd0 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*)+0x460
  pc 0x000000011076062c fp 0x000070000d0fbe10 dart::ThreadPool::Worker::Main(unsigned long)+0x12c
  pc 0x0000000110694f48 fp 0x000070000d0fbf80 dart::ThreadStart(void*)+0x238
  pc 0x0000000111417397 fp 0x000070000d0fbfb0 asan_thread_start(void*)+0x47
  pc 0x00007ff8171971d3 fp 0x000070000d0fbfd0 _pthread_start+0x7d
  pc 0x00007ff817192bd3 fp 0x000070000d0fbff0 thread_start+0xf
-- End of DumpStackTrace

example log

This looks like it might be a linking issue with the FFI test library.

[dcharkes]

This looks like it might be a linking issue with the FFI test library.

This looks similar to the issues we had before on Linux. IIRC, it was that the cpp std lib wasn't instrumented.

• ffi_2/function_callbacks_test crashing on dartk-msan-linux-release-x64 #43075
• [vm/ffi] Updating double-conversion causes std::cout to segfault in FFI calls on MacOS #47835