-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.
Description
Hi! I was taking a look at the brand type generation code and I noticed some opportunities for improvement.
- The
_brandTypeFieldValuescould also include nullable and non-nullable references toi31,struct, andarray, as well asi8andi16. - The comments discuss working around structural subtyping issues, but WebAssembly does not have structural subtyping on defined types, so:
- It should be fine for a brand type to have zero fields.
- It should be fine to use mutable fields in the brand types, doubling the effective digits.
cc @natebiggs
Metadata
Metadata
Assignees
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.