Failures on vm/dart/align_loops_verify_alignment_test and vm/dart/gc/splay_test.dart

[jyameo]

There are new test failures on [vm] Carry over argdescriptors from vm-isolate...[vm] Don't generate gen_snapshot targeting ARM/RISCV64 for ARM64C/X64C..

The tests

language/records/simple/constants_and_field_access_test/1 Crash (expected Pass)
vm/dart/align_loops_verify_alignment_test RuntimeError (expected Pass)
vm/dart/checked_parameter_assert_assignable_stacktrace_test/2 Crash (expected Pass)
vm/dart/gc/splay_test/25 Crash (expected Pass)

are failing on configurations

vm-aot-linux-debug-simarm_x64
vm-linux-debug-x64

Test results:

• vm/dart/align_loops_verify_alignment_test
• vm/dart/gc/splay_test/25

logs:

• https://dart-ci.appspot.com/log/vm-linux-debug-x64/vm-linux-debug-x64/5663/vm/dart/align_loops_verify_alignment_test
• https://dart-ci.appspot.com/log/vm-aot-linux-debug-simarm_x64/vm-aot-linux-debug-simarm_x64/5299/vm/dart/checked_parameter_assert_assignable_stacktrace_test/2

[alexmarkov]

Relevant stack trace:

../../runtime/vm/compiler/backend/il_serializer.cc: 112: error: expected: !array_.InVMIsolateHeap()
version=3.9.0-edge (main) (Unknown timestamp) on "linux_x64"
pid=1523727, thread=1523727, isolate_group=isolate(0x63b77b81cb00), isolate=(nil)((nil))
os=linux, arch=x64, comp=no, sim=no
isolate_instructions=0, vm_instructions=0
fp=7ffc97d6c760, sp=7ffc97d6c730, pc=63b758a339e6
  pc 0x000063b758a339e6 fp 0x00007ffc97d6c760 dart::Profiler::DumpStackTrace+0x26
  pc 0x000063b7587661c2 fp 0x00007ffc97d6c840 dart::Assert::Fail+0x82
  pc 0x000063b75905351f fp 0x00007ffc97d6c880 dart::ArgumentsDescriptor::Write+0x25f
  pc 0x000063b759065ab1 fp 0x00007ffc97d6c900 dart::FlowGraphSerializer::WriteObjectImpl+0x971
  pc 0x000063b75903d005 fp 0x00007ffc97d6c930 dart::StaticCallInstr::WriteTo+0x25
  pc 0x000063b7590592b2 fp 0x00007ffc97d6c990 dart::FlowGraphSerializer::WriteFlowGraph+0x212
  pc 0x000063b7591014f6 fp 0x00007ffc97d6cb00 dart::CompilerPass_TestILSerialization::DoBody+0xf6
  pc 0x000063b7590ffbad fp 0x00007ffc97d6cbd0 dart::CompilerPass::Run+0x18d
  pc 0x000063b75910023b fp 0x00007ffc97d6cbf0 dart::CompilerPass::RunPipeline+0x36b
  pc 0x000063b758fa1fb1 fp 0x00007ffc97d6d030 dart::PrecompileParsedFunctionHelper::Compile+0x241
  pc 0x000063b758f9cd82 fp 0x00007ffc97d6d890 dart::Precompiler::CompileFunction+0x362
  pc 0x000063b758a478ce fp 0x00007ffc97d6d8d0 dart::ProgramWalker::VisitFunction+0x3e
  pc 0x000063b758a44c18 fp 0x00007ffc97d6d910 dart::ProgramWalker::VisitWorklist+0xc8
  pc 0x000063b758a4458f fp 0x00007ffc97d6da50 dart::ProgramVisitor::WalkProgram+0x38f
  pc 0x000063b758f94138 fp 0x00007ffc97d6daf0 dart::Precompiler::PrecompileConstructors+0x68
  pc 0x000063b758f90d2a fp 0x00007ffc97d6ea40 dart::Precompiler::DoCompileAll+0x30a
  pc 0x000063b758f90974 fp 0x00007ffc97d6eec0 dart::Precompiler::CompileAll+0xa4
  pc 0x000063b7591eb046 fp 0x00007ffc97d6f0b0 Dart_Precompile+0x156
  pc 0x000063b7587376b0 fp 0x00007ffc97d6f220 dart::bin::main+0xb10
-- End of DumpStackTrace

This crash is likely caused by 5e77a23. /cc @mraleph

[mraleph]

The assert is checking the property that no longer holds - but nobody relies on that anywhere, so I am just going to remove it.