Can't retrieve environment declarations passed as arguments to `dart run`

[parlough]

Retrieving environment declarations passed to dart run stopped working (tested on 3.10.0-49.0.dev and 3.10.0-118.0.dev). I'm assuming due to ab44b20 or related preparation work. If I pass them to the base dart CLI they do work, but I would expect them to be accepted as arguments to the run subcommand (which is documented as an option).

With a code snippet, like the following.

const bool shouldSayHello = bool.fromEnvironment('hello');

void main() {
  print(shouldSayHello);
}

Both the following commands print "false", when I would expect them to print "true".

dart run --define=hello=true bin/main.dart
dart run -D=hello=true bin/main.dart

If I pass them to the base dart CLI instead of the subcommand, they do print "true".

dart --define=hello=true run bin/main.dart
dart -D=hello=true run bin/main.dart

\cc @a-siva @bkonyi

[lrhn]

Try using const bool.fromEnvironment('hello').
That is defined to work.

Using the fromEnvironment constructors to access the compilation environment without const, so at runtime, can only work if the compilation environment is included in the runtime.

Most (all?) AoT compilers do not include the compilation environment in their deployable output, so using it without const only really works for the JIT VM which compiles and runs in the same process.

(Intermediate compilation artifacts for modular compulsion may need to include the environment that it has actually accessed, because there is a requirement that if anyone uses const String.fromEnvironment(s) in two places with the same s, the result must be the same. It should be a complication error to combine code compiled with different civilisation environments if that difference is accessed.)

[parlough]

Try using const bool.fromEnvironment('hello').
That is defined to work.

I declared the variable as const, so shouldn't that be inferred and be the same?

Trying const bool.fromEnvironment('hello') directly though, the environment declarations are still missing.

JIT VM which compiles and runs in the same process.

Perhaps this is related to the problem though. In 3.10, weren't the CLI and the VM separated? So now dart run is executing a separate dartvm process and not updated to properly include the environment declarations.

[lrhn]

I declared the variable as const, so shouldn't that be inferred and be the same?

It should, I missed that. My bad.
Then it should work.

[parlough]

It ended up being (I believe) an unintentional omission. I opened a CL at https://dart.dev/cl/446681