co19/LanguageFeatures/Parts-with-imports/scope_A06_t03 fails on dart2js-hostasserts-linux-d8

[sgrekhov]

The test passes on all other platforms but fails on dart2js-hostasserts-linux-d8.

/========================================================================================================\
| co19/LanguageFeatures/Parts-with-imports/scope_A06_t03 is new and failed (RuntimeError, expected Pass) |
\========================================================================================================/

--- Command "dart2js" (took 02.000442s):
DART_CONFIGURATION=ReleaseX64 sdk/bin/dart2js_developer -Dtest_runner.configuration=dart2js-hostasserts-linux-d8 --enable-experiment=enhanced-parts --test-mode --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/tests/co19/src/LanguageFeatures/Parts-with-imports/scope_A06_t03.dart --out=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js

exit code:
0

stdout:
Compiled 10,298,719 input bytes (5,280,673 characters source) to 205,236 characters JavaScript in 2.43 seconds using 328.363 MB of memory

--- Command "d8" (took 99ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03 /b/s/w/ir/third_party/d8/linux/x64/d8 /b/s/w/ir/sdk/lib/_internal/js_runtime/lib/preambles/seal_native_object.js /b/s/w/ir/sdk/lib/_internal/js_runtime/lib/preambles/d8.js /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js

exit code:
1

stdout:
/b/s/w/ir/sdk/lib/_internal/js_runtime/lib/preambles/d8.js:265: Expect.equals(expected: <scope_lib1 libVar>, actual: <scope_lib1 libVar>) fails.
          throw e;
          ^

    at Object.wrapException (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:473:47)
    at Object._fail (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:3541:15)
    at /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:3578:17
    at _wrapJsFunctionForAsync_closure.$protected (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:2851:15)
    at _wrapJsFunctionForAsync_closure.call$2 (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:4394:12)
    at _awaitOnObject_closure.call$1 (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:4382:32)
    at _RootZone.runUnary$2$2 (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:4854:18)
    at _Future__propagateToListeners_handleValueCallback.call$0 (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:4769:51)
    at Object._Future__propagateToListeners (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:3032:93)
    at _Future._completeWithValue$1 (/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js-hostasserts-linux-d8/tests_co19_src_LanguageFeatures_Parts-with-imports_scope_A06_t03/scope_A06_t03.js:4628:9)

Deobfuscated error and stack:

    at wrapException                                            org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1376:19
    at _fail                                                    ../../../../../tests/co19/src/Utils/expect.dart 18:5
    at equals(inlined)                                          ../../../../../tests/co19/src/Utils/expect_common.dart 15:7
    at testPart2                                                ../../../../../tests/co19/src/LanguageFeatures/Parts-with-imports/scope_A06_t03_part2.dart 40:10
    at _awaitOnObject                                           org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 339:19
    at _wrapJsFunctionForAsync.<anonymous>                      org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 365:23
    at _awaitOnObject.<anonymous>                               org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 313:7
    at _RootZone.runUnary                                       org-dartlang-sdk:///lib/async/zone.dart 1849:46
    at _zone(inlined)                                           org-dartlang-sdk:///lib/async/future_impl.dart 186:29
    at handleValue(inlined)                                     org-dartlang-sdk:///lib/async/future_impl.dart 222:12
    at _Future._propagateToListeners.handleValueCallback        org-dartlang-sdk:///lib/async/future_impl.dart 948:36
    at _Future._propagateToListeners                            org-dartlang-sdk:///lib/async/future_impl.dart 977:13
    at _Future._completeWithValue                               org-dartlang-sdk:///lib/async/future_impl.dart 720:5


--- Re-run this test:
python3 tools/test.py -n dart2js-hostasserts-linux-d8 co19/LanguageFeatures/Parts-with-imports/scope_A06_t03

[biggs0125]

It seems like there's a bug in dart2js's static analysis here. Looking at the compiled code, we end up inlining the failure from Expect.equals into testPart2. Which means dart2js thinks that statically the two strings in question are not equal. I'm digging into why.

This test should be failing on all the dart2js bots. The test is async but is not awaiting testPart2 or using the async helpers asyncStart and asyncEnd. So the failure is being incorrectly suppressed on the chrome configs.