Field destructing completion shows no results when file is not formatted

[FMorschel]

I'm not exactly sure what the parser/resolver is doing here, but I could not come up with a simpler repro:

import 'package:analyzer/dart/ast/ast.dart';

void f(ClassMember member) {
  if (member
      case 
          FieldDeclaration(fields: VariableDeclarationList(
            :^
          ))) {
          
  }
}

Interestingly, the same code but with a different formatting:

import 'package:analyzer/dart/ast/ast.dart';

void f(ClassMember member) {
  if (member case FieldDeclaration(fields: VariableDeclarationList(:^))) {}
}

Works as intended.

I'll look into this. I've tested it superficially, and it seems to be a simple fix. The difference between these is that the first case is trying to add completion in a PatternFieldName after the colon (which we currently don't handle), and the second case is trying to add completion in a PatternField.

FYI @bwilkerson @srawlins

[FMorschel]

Okay, it seems that this only happens because the : is in another line by itself.

[FMorschel]

This is a simpler repro:

void f(MyClassWithReallyBigName parameter) {
  if (parameter case MyClassWithReallyBigName(
    fieldWithBigName: var fieldWithReallyVeryBigName,
    :^
  )) {}
}

abstract class MyClassWithReallyBigName {
  int get fieldWithBigName;
}

The : can be either in the new line as is or at the previous line after the variable declaration.

[FMorschel]

Here is the CL https://dart-review.googlesource.com/c/sdk/+/460142

[bwilkerson]

For future reference, the insights page can display the AST structure in an outline format, which sometimes makes it easier to figure out things like how recovery is working.