Analyzer does not report repeated field initialization

[lrhn]

Example:

class C {
  int x;
  C.n1(this.x) : x = x; // INVALID
  C.n2(int x) : x = x, x = x; // INVALID
}
void main() {}

The specification states:

It is a compile-time error if more than one initializer corresponding
to a given instance variable appears in $k$'s initializer list.
It is a compile-time error if $k$'s initializer list contains
an initializer for a variable that is initialized by means of
an initializing formal of $k$.

so both C.n1 and C.n2 should be errors.

The analyzer fails to report C.n1 and C.n2 as errors, the CFE reports:

invalidreinit.dart:3:20: Error: 'x' was already initialized by this constructor.
  C.n1(this.x) : x = x; // INVALID
                   ^
invalidreinit.dart:4:26: Error: 'x' was already initialized by this constructor.
  C.n2(int x) : x = x, x = x; // INVALID
                         ^

[johnniwinther]

cc @scheglov

[scheglov]

I cannot reproduce this, the analyzer reports the same errors.

[lrhn]

Ack, my bad. I simplified the example too far without re-testing.

If you change int x; to int x = 0;, the required errors go away.

class C {
  int x = 0;
  C.n1(this.x) : x = x; // INVALID
  C.n2(int x) : x = x, x = x; // INVALID
}

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/462541