`Convert Getter to Method` refactor wrong behaviour with pattern destructuring

[FMorschel]

Repro:

class C {
  int? get foo => null;
}

void f(C c) {
  if (c case C(:final foo)) {}
}

Gets refactored into:

class C {
  int? foo() => null;
}

void f(C c) {
  if (c case C(():final foo)) {}
}

The (): syntax is invalid and an unnecessary change. We should be adding () wherever the local variable is being used instead. I'll take a look at this.

FYI @bwilkerson @srawlins @DanTup

[FMorschel]

I've opened https://dart-review.googlesource.com/c/sdk/+/465360 so we can at least fix the (): part. Now, I still have to think about how we could know what local variable references we should add the () instead.

If anyone has a good idea, I'm up to it. We almost need the search result to contain that element reference, but that doesn't seem like a reasonable idea.

[bwilkerson]

We should be adding () wherever the local variable is being used instead.

Accessing a local variable can't have side-effects; invoking a method can.

There isn't a single always-right way to fix this usage, so it seems like it might be better for the refactoring to warn the user (with a refactor-anyway) option, and to leave the code broken rather than trying to make changes that the user might miss and that are wrong.