Skip to content

Extract matchTypes from matchAnnotation. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Extract matchTypes from matchAnnotation. #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a61ec6
Extract matchTypes from matchAnnotation.
alorenzen Jan 5, 2017
5492384
Add dartdoc comments for matchAnnotation() and matchTypes().
alorenzen Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/src/annotation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,25 @@ DeclarationMirror _getDeclarationMirrorFromType(InterfaceType type) {
return libMirror.declarations[typeNameSymbol];
}

/// Checks whether the constant type of [annotation] is equivalent to
/// [annotationType].
bool matchAnnotation(Type annotationType, ElementAnnotation annotation) {
var classMirror = reflectClass(annotationType);
var classMirrorSymbol = classMirror.simpleName;

var annotationValueType = annotation.constantValue?.type;
if (annotationValueType == null) {
throw new ArgumentError.value(annotation, 'annotation',
'Could not determine type of annotation. Are you missing a dependency?');
}

return matchTypes(annotationType, annotationValueType);
}

/// Checks whether [annotationValueType] is equivalent to [annotationType].
///
/// Currently, this uses mirrors to compare the name and library uri of the two
/// types.
bool matchTypes(Type annotationType, ParameterizedType annotationValueType) {
Copy link
Member

@natebosch natebosch Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a Doc comment?

Copy link
Contributor Author

@alorenzen alorenzen Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

var classMirror = reflectClass(annotationType);
var classMirrorSymbol = classMirror.simpleName;

var annTypeName = annotationValueType.name;
var annotationTypeSymbol = new Symbol(annTypeName);
Expand Down