Extract matchTypes from matchAnnotation. #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract matchTypes from matchAnnotation so that it can be used in cases where the type comes from a different source (like a DartObject instance).
kevmoo
requested changes
Jan 5, 2017
natebosch
reviewed
Jan 6, 2017
| return matchTypes(annotationType, annotationValueType); | ||
| } | ||
|
|
||
| bool matchTypes(Type annotationType, ParameterizedType annotationValueType) { |
|
I'm on board with the change. Will wait to merge it in until I get a chance to sync with @kevmoo |
matanlurey
pushed a commit
to angulardart/angular
that referenced
this pull request
Jan 18, 2017
See dart-lang/source_gen#116 for the corresponding source_gen PR. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144028180
matanlurey
pushed a commit
to angulardart/angular
that referenced
this pull request
Jan 18, 2017
See dart-lang/source_gen#116 for the corresponding source_gen PR. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144028180
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
Extract matchTypes from matchAnnotation so that it can be used in cases where the type comes from a different source (like a DartObject instance).
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
Extract matchTypes from matchAnnotation so that it can be used in cases where the type comes from a different source (like a DartObject instance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract matchTypes from matchAnnotation so that it can be used in cases where the type comes from a different source (like a DartObject instance).