Add findType, and fix a bug in TypeChecker. #165
Conversation
| /// because it relies on knowing the _absolute_ path (i.e. after resolved | ||
| /// `export` directives). You should ideally only use `fromUrl` when you know | ||
| /// the full path (likely you own/control the package) or it is in a stable | ||
| /// package like in the `dart:` SDK. |
There was a problem hiding this comment.
Maybe "stable package or the Dart SDK via dart: URLs.
| void main() { | ||
| LibraryElement library; | ||
|
|
||
| setUpAll(() async { |
There was a problem hiding this comment.
Just curious, I notice you use this setUpAll a lot but I don't understand what the value is over just regular setup in the top of main?
There was a problem hiding this comment.
setUpAll is only invoked once, not once per test.
The body of this function (doing analysis) is expensive, and doesn't change between tests, so this makes the test take ~20s instead of minutes.
There was a problem hiding this comment.
main is only invoked once as well :).
I talked with @kevmoo and I guess you get better errors if the setup fails at least so there is that advantage. Also if all tests end up skipped then it wouldn't execute this code.
There was a problem hiding this comment.
Yeah, also it makes the use of async a little cleaner.
4 participants
Closes #160.
Also added test cases, which in turn found a bug. Whad'ya know @jakemac53 🐑
Closes #161.