Clean up --help #1331
Merged
Clean up --help #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Sep 1, 2020
| parser.addFlag('verbose-trace', | ||
| negatable: false, | ||
| help: 'Whether to emit stack traces with core library frames.'); | ||
| negatable: false, help: 'Emit stack traces with core library frames.'); |
Member
There was a problem hiding this comment.
Do you know why this isn't negatable? This came up on the doc.
Member
Author
There was a problem hiding this comment.
I found the PR that added the flag: b61a536
Doesn't have a reason though.
devoncarew
approved these changes
Sep 2, 2020
| @@ -1,5 +1,5 @@ | |||
| name: test | |||
| version: 1.16.0-nullsafety.2 | |||
| version: 1.16.0-nullsafety.3 | |||
Contributor
There was a problem hiding this comment.
I assume this means that users won't see the help text changes until they're using a null safe version of package:test?
Member
There was a problem hiding this comment.
That is correct, but using a null safe compatible version of package:test does not require that the user migrates to null safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
--helpto better align with other commands captured in Dart CLI.Closes #1330