Fix travis hack #672
Merged
Fix travis hack #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Aug 4, 2017
Member
natebosch
left a comment
natebosch
left a comment
There was a problem hiding this comment.
Still hoping we can find the root cause - but this is a good compromise to unblock flutter.
Member
Author
|
I thought I found the issue in #654 but fixing it didn't seem to impact the flakiness (I'll still merge this change later today). Now that I know which shard is consistently causing issues hopefully I can use that information to root cause the problem. That being said, this issues hasn't been a huge priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing an exit on Travis is negatively impacting those that collect code coverage after a test is run. The belief is that this hack is necessary only for a subset of tests within package:test itself. Updating the logic so that it makes use of a more specific environment variable.