Update pkg:pedantic for all packages, fix associated unawaited lints #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Dec 28, 2018
| // See SDK issue: https://github.com/dart-lang/sdk/issues/31264 | ||
| for (var stream in _ioSubscriptions) { | ||
| stream.cancel(); | ||
| unawaited( stream.cancel()); |
natebosch
approved these changes
Dec 28, 2018
Member
natebosch
left a comment
natebosch
left a comment
There was a problem hiding this comment.
Approving since this doesn't change behavior. Can you file an issue to have Gary or I look at those canceled stream subscriptions that aren't awaited?
kevmoo
force-pushed
the
i943_fix_future_import
branch
from
94d627a to
73b0913
Compare
Member
Author
Will do once this lands – so I can point to the code... That's the nice thing about this lint, I think. Makes it easy to find/review all of the cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.