Fix test hang and prep for release - 0.12.26+1 #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Nov 1, 2017
grouma
changed the title
nex3
approved these changes
Nov 1, 2017
lib/src/runner/browser/browser.dart
Outdated
| final _onExitCompleter = new Completer(); | ||
|
|
||
| /// IO streams for the underlying browser process. | ||
| final _ioStreams = <StreamSubscription>[]; |
Member
There was a problem hiding this comment.
Nit: I'd call this _ioSubscriptions.
lib/src/runner/browser/browser.dart
Outdated
| Future get onExit => _onExitCompleter.future; | ||
| final _onExitCompleter = new Completer(); | ||
|
|
||
| /// IO streams for the underlying browser process. |
| _closed = true; | ||
|
|
||
| // If we don't manually close the stream the test runner can hang. | ||
| // For example this happens with Chrome Headless. |
Member
There was a problem hiding this comment.
Did you file a dart:io bug for this? If so, refer to it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We declared an incorrect constraint for package stack_trace. This was fixed in #714
Also fixing potential test hangs by manually closing IO streams.
Preparing for a new release.