Workaround for async SDK issue #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Mar 19, 2018
nex3
reviewed
Mar 19, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 0.12.32+2 | |||
|
|
|||
| * Provide a work around for dart-lang/sdk/issues/32556. | |||
Member
There was a problem hiding this comment.
This doesn't really communicate to downstream users what changed. Those users don't care what the SDK bug was, they care what user-visible thing was going wrong that is now fixed. Consider writing something like "Work around an SDK bug that caused timeouts in asynchronous code."
Also, for future reference, it's probably a good idea to use a link that users can follow rather than something like dart-lang/sdk/issues/32556.
Member
Author
|
Added back the "unnecessary cast". This will have to be removed when dev becomes stable. I will also need to merge with a failing Travis due to #788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.