Skip to content

Workaround for async SDK issue #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Workaround for async SDK issue #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9669fdc
workaround for sdk issue
grouma Mar 19, 2018
701904e
add back cast and update changelog
grouma Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.12.32+2

* Work around an SDK bug that caused timeouts in asynchronous code.

## 0.12.32+1

* Fix a bug that broke content shell on Dart 1.24.
Expand Down
4 changes: 4 additions & 0 deletions lib/src/runner/remote_listener.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ class RemoteListener {
channel.sink.add({"type": "print", "line": line});
});

// Work-around for https://github.com/dart-lang/sdk/issues/32556. Remove
// once fixed.
new Stream.fromIterable([]).listen((_) {}).cancel();

new SuiteChannelManager().asCurrent(() {
new StackTraceFormatter().asCurrent(() {
runZoned(() async {
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test
version: 0.12.32+1
version: 0.12.32+2
author: Dart Team <misc@dartlang.org>
description: A library for writing dart unit tests.
homepage: https://github.com/dart-lang/test
Expand Down