Stabilize JS Interop CI and decouple webref dependencies by kevmoo · Pull Request #532 · dart-lang/web

kevmoo · 2026-04-14T20:19:52Z

Created new js_interop_gen package that doesn't know about pkg:web
Removed @webref dependencies from js_interop_gen/lib/src/package.json to prevent implicit runtime reliance on the external @webref ecosystem.
Refactored generateBindingsForFiles in generate_bindings.dart to pass an empty JS object instead of relying on missing global JS state for CSS and element definitions, resolving runtime crashes when dependencies were removed.
Updated idl_test.dart to use the real BCD file from web_generator to satisfy the parser and keep tests passing, while adding a TODO to track the removal of this cross-package dependency in the future.
Fixed analyzer issues in generate_bindings.dart related to type inference on collection literals and line length limits.
Added GitHub CI status badges to the root README.md for all packages in the repository, removing the stale TODO comment.

gemini-code-assist

Code Review

This pull request refactors the interop_generator by moving Web IDL-specific generation logic into a new web_generator package and introducing a JSON-based data flow for IDL, CSS, and browser compatibility data. This change decouples the core generator from direct dependencies on Node.js packages like @webref. Feedback focuses on improving the robustness of the implementation by addressing unsafe type casts during library analysis, potential type errors when accessing JSON maps, and a possible StateError in a list manipulation utility.

- Renamed package from `interop_generator` to `js_interop_gen` to align with the monorepo structure. - Removed `@webref` dependencies from `js_interop_gen/lib/src/package.json` to prevent implicit runtime reliance on the external `@webref` ecosystem. - Refactored `generateBindingsForFiles` in `generate_bindings.dart` to pass an empty JS object instead of relying on missing global JS state for CSS and element definitions, resolving runtime crashes when dependencies were removed. - Updated `idl_test.dart` to use the real BCD file from `web_generator` to satisfy the parser and keep tests passing, while adding a TODO to track the removal of this cross-package dependency in the future. - Fixed analyzer issues in `generate_bindings.dart` related to type inference on collection literals and line length limits. - Added GitHub CI status badges to the root `README.md` for all packages in the repository, removing the stale TODO comment.

kevmoo · 2026-04-15T17:32:56Z

I think this is ready for review @srujzs

CC @nikeokoronkwo and @nex3

kevmoo · 2026-04-15T17:33:07Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the project by extracting the core binding generation logic into a new package, js_interop_gen, and specializing web_generator for package:web. It introduces CLI options for pre-parsed IDL and browser-compat-data JSON files, adds support for async_iterable, and moves MDN conversion logic to a dedicated library. Feedback was provided to correct typos in the js_interop_gen documentation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

nikeokoronkwo · 2026-04-15T17:42:12Z

Thank you @kevmoo

I would like to ask, would "jsigen" be a good name: it matches the names of other gen packages in the dart ecosystem ("ffigen", "jnigen", etc)?

cc @srujzs

kevmoo · 2026-04-15T18:00:54Z

Thank you @kevmoo

I would like to ask, would "jsigen" be a good name: it matches the names of other gen packages in the dart ecosystem ("ffigen", "jnigen", etc)?

cc @srujzs

Ooo! not a bad idea!

srujzs · 2026-04-15T19:28:30Z

#475 (comment)

I agree with Daco here that spelling it out is better and is consistent with dart:js_interop/package:js_interop like how ffigen is consistent with dart:ffi/package:ffi and jnigen has package:jni.

kevmoo · 2026-04-15T19:36:09Z

@srujzs – so you're saying leave it as is in the PR?

kevmoo · 2026-04-15T19:38:36Z

+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';


Moving this OUT of the core logic. Running the generator shouldn't update the generator!!

The code does yell if it needs updating, though!

kevmoo · 2026-04-15T19:38:58Z

@@ -1,4 +1,3 @@
-[![package:web](https://github.com/dart-lang/web/actions/workflows/web.yaml/badge.svg)](https://github.com/dart-lang/web/actions/workflows/web.yaml)


No need to advertise the CURRENT CI status on the package site!

kevmoo · 2026-04-15T19:39:18Z

  return null;
 }

-String convertMdnToMarkdown(String content) {


This was moved to a library so we could unit test it!

kevmoo · 2026-04-15T19:39:52Z

 import 'package:test/test.dart';

-import '../bin/scrape_mdn.dart';
+import 'package:web_generator/src/mdn_converter.dart';


importing things from bin in tests - not good!

kevmoo · 2026-04-15T19:40:31Z

-web_generator/lib/src/*.js
-web_generator/lib/src/*.js.*
-web_generator/lib/src/node_modules/
+js_interop_gen/lib/src/*.js


If we ever want to PUBLISH this package, we'll need to include the JS bits so it works outside of the repo!

srujzs · 2026-04-15T19:43:44Z

@srujzs – so you're saying leave it as is in the PR?

That's my preference, yes.

kevmoo · 2026-04-15T19:50:46Z

@srujzs – so you're saying leave it as is in the PR?

That's my preference, yes.

LOL – I guess it was your initial suggestion! 😆

nikeokoronkwo · 2026-04-16T19:59:58Z

+run on Node.
+
+There is one entrypoint present in this package:
+- `js_interop_gen.dart`: This entrypoint is for generating Dart interfaces from TS Declaration code, given the path to a `.d.ts` file


*or an IDL file (it seems this package still works with IDL code)

srujzs

A step closer into full disentanglement, yay!

- Centralize generated assets (web_apis.json, dummy_bcd.json) into package-specific subdirectories under .dart_tool. - Remove hardcoded web_apis.json and dummy_bcd.json from the repository. - Update update_idl_bindings.dart to automatically run preparse_idls.mjs when needed. - Make JSON casts and lookups in bcd.dart more robust to avoid TypeErrors with minimal data. - Remove redundant npm install step for web_generator in js_interop_gen.yaml workflow. - Update tests to use the new ignored paths.

kevmoo · 2026-04-18T05:49:41Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the repository by extracting general-purpose JS interop generation logic into a new package, js_interop_gen, while repurposing web_generator for internal package:web specific tasks. The changes involve moving core AST, translation, and CLI logic, updating dependencies, and refactoring data fetching to support external JSON paths for IDL and browser compatibility data. Feedback focuses on improving the robustness of the generated file check by normalizing line endings to prevent false positives on Windows and ensuring consistent command-line instructions in warning messages and file headers.

kevmoo · 2026-04-18T18:28:38Z

@srujzs

kevmoo · 2026-04-18T18:28:47Z

...like...approve?

srujzs

Thanks!

…, webdev, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/3d3b7fd..7270c43): 7270c43 Wed Apr 29 01:14:51 2026 +0530 Sourav-Sonkar fix: graceful shutdown of orphaned test apps on windows (dart-lang/ai#438) 07af327 Tue Apr 28 11:11:31 2026 -0700 Jacob MacDonald Update dependencies (dart-lang/ai#453) ff1866d Wed Apr 29 00:13:33 2026 +0800 Goweii fix: Add empty properties object to tool input schemas to resolve Claude 400 validation error (dart-lang/ai#444) 8ce7450 Thu Apr 16 11:03:55 2026 -0700 Jacob MacDonald add gemini code assist configuration for reviews (dart-lang/ai#443) 899e562 Tue Apr 14 11:38:29 2026 -0700 Jacob MacDonald Merge cherry-pick branch into main (dart-lang/ai#442) 5eae0ae Tue Apr 14 18:27:49 2026 +0000 Jake Macdonald Merge remote-tracking branch 'origin/cherry-pick' into merge-cherry-pick 1e69aa8 Tue Apr 14 11:20:43 2026 -0700 Jacob MacDonald re-implement most of `#440` for the current stable release (dart-lang/ai#441) core (https://github.com/dart-lang/core/compare/347df4b..be0b1531): be0b1531 Wed Apr 29 16:50:55 2026 -0700 Nate Bosch Revert "Completely new cross-platform API introduced" (#957) a23519da Mon Apr 20 15:57:58 2026 -0700 Nate Bosch Support variable duration in RestartableTimer (dart-lang/core#949) 0def20c4 Thu Apr 2 08:40:37 2026 +0200 Lasse R.H. Nielsen Completely new cross-platform API introduced dartdoc (https://github.com/dart-lang/dartdoc/compare/c01cf53..2e30b8e): 2e30b8e3 Tue Apr 21 15:09:21 2026 -0700 Kevin Moore Improve @canonicalFor validation with close-match suggestions (dart-lang/dartdoc#4234) fbc326ea Tue Apr 14 09:18:26 2026 -0700 Kevin Moore Fix dartdoc canonicalization for explicit getters and prioritize @canonicalFor (dart-lang/dartdoc#4233) ecosystem (https://github.com/dart-lang/ecosystem/compare/3bd43d6..ed4e053): ed4e053 Wed Apr 15 08:30:59 2026 -0700 Kevin Moore fix(workflows): prevent duplicate PR comments in post_summaries.yaml (dart-lang/ecosystem#412) http (https://github.com/dart-lang/http/compare/fa2d2c2..2c84f24): 2c84f24 Mon Apr 27 14:45:17 2026 -0700 Brian Quinlan doc: s/dart:html/package:web/g (dart-lang/http#1911) i18n (https://github.com/dart-lang/i18n/compare/de7e11b..2ae32fd): 2ae32fdd Wed Apr 22 02:20:51 2026 -0700 Googler No public description 1eaf8a2e Sun Mar 1 06:51:04 2026 +0000 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/i18n#1053) shelf (https://github.com/dart-lang/shelf/compare/c4b94d3..cc6b57d): cc6b57d Wed Apr 29 08:59:40 2026 -0700 Kevin Moore chore: update shelf_io test to not crash on certificate error (dart-lang/shelf#522) da9f1b1 Thu Apr 23 14:43:00 2026 -0400 Mouad Debbar Fix multi-header handling in shelf_proxy (dart-lang/shelf#519) a6693a9 Wed Apr 22 23:15:09 2026 -0700 Kevin Moore feat: Add HTTP/1.1 compliance testing package and baseline for shelf (dart-lang/shelf#518) test (https://github.com/dart-lang/test/compare/8bbb847..d5da922): d5da9229 Mon Apr 27 17:32:33 2026 -0700 Jacob MacDonald Expose the backend APIs used by flutter_test from test_api (dart-lang/test#2635) c8c76f45 Mon Apr 27 13:38:25 2026 -0700 Nate Bosch Prepare to publish (dart-lang/test#2634) web (https://github.com/dart-lang/web/compare/15599ee..7c908b1): 7c908b1 Tue Apr 28 17:16:57 2026 -0700 Kevin Moore test(js_interop_gen): add integration tests (dart-lang/web#541) 5ed9bed Tue Apr 28 17:04:41 2026 -0700 Kevin Moore js_interop_gen: minimize the number of `@docImport` comments we create (dart-lang/web#540) 2c47e36 Mon Apr 27 20:55:43 2026 -0700 Kevin Moore feat: generate descriptive documentation for union typedefs (dart-lang/web#534) db91caf Mon Apr 27 15:15:30 2026 -0700 Kevin Moore chore: write BCD version to README in web_generator (dart-lang/web#537) 5e7285f Fri Apr 24 12:09:10 2026 -0700 Kevin Moore chore: update node invocation to use the source maps we already generate (dart-lang/web#538) 3a7e37a Sat Apr 18 19:31:20 2026 -0700 Kevin Moore Stabilize JS Interop CI and decouple webref dependencies (dart-lang/web#532) d7daf7d Tue Apr 14 12:23:21 2026 -0700 Kevin Moore generator: add some sanity to the language version logic (dart-lang/web#530) b026317 Mon Apr 13 13:01:37 2026 -0700 Kevin Moore generator: be more robust against NPM timing issues (dart-lang/web#528) webdev (https://github.com/dart-lang/webdev/compare/2947c78..d33d270): d33d2704 Thu Apr 23 16:00:22 2026 -0400 Jessy Yameogo [dwds] Sync state with sdk/g3 and restore static analysis for fixtures (dart-lang/webdev#2824) e43744b2 Fri Apr 17 16:55:24 2026 -0400 Jessy Yameogo [dwds] Fix ping event serialization by introducing PingRequest (dart-lang/webdev#2821) 1063eb00 Fri Apr 17 10:28:47 2026 -0700 MarkZ Creating experimental flag for web hot reload in webdev and splitting tests between DDC module systems (dart-lang/webdev#2807) webdriver (https://github.com/google/webdriver.dart/compare/26326d3..3a711eb): 3a711eb Mon Apr 27 10:09:31 2026 -0700 Kevin Moore Update CI badge to point to master branch (google/webdriver.dart#343) R=bquinlan@google.com Change-Id: Ie746dfd8f9637db46075b252d3290925de11b382 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499663 Reviewed-by: Brian Quinlan <bquinlan@google.com> Commit-Queue: Nate Bosch <nbosch@google.com>

gemini-code-assist Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread js_interop_gen/lib/src/cli.dart

Comment thread js_interop_gen/lib/src/generate_bindings.dart Outdated

Comment thread web_generator/lib/src/mdn_converter.dart Outdated

kevmoo changed the base branch from organize_logic to main April 15, 2026 15:49

kevmoo force-pushed the new_web_generator branch from 5463a6c to c01f30c Compare April 15, 2026 16:14

kevmoo changed the title ~~new web_generator~~ Stabilize JS Interop CI and decouple webref dependencies Apr 15, 2026

kevmoo added 7 commits April 15, 2026 09:46

ci fixes ad review nits

9ddddf5

fix formatting

dcc4e35

more ci fighting

82f44d3

more better?

577b614

even better

e601fd2

more better?

47b5cee

more final tweaks

cd6263d

kevmoo requested a review from srujzs April 15, 2026 17:31

gemini-code-assist Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread js_interop_gen/README.md Outdated

Update js_interop_gen/README.md

3302d01

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

kevmoo commented Apr 15, 2026

View reviewed changes

nikeokoronkwo reviewed Apr 16, 2026

View reviewed changes

srujzs reviewed Apr 18, 2026

View reviewed changes

kevmoo added 4 commits April 17, 2026 22:41

better

68b30f4

better

927e722

description silly fix

93f1c18

gemini-code-assist Bot reviewed Apr 18, 2026

View reviewed changes

Comment thread js_interop_gen/lib/src/cli.dart Outdated

Comment thread js_interop_gen/lib/src/cli.dart Outdated

more review nits

a2e3c33

srujzs approved these changes Apr 19, 2026

View reviewed changes

kevmoo merged commit 3a7e37a into main Apr 19, 2026
22 checks passed

kevmoo deleted the new_web_generator branch April 19, 2026 02:31

		@@ -1,4 +1,3 @@
		[![package:web](https://github.com/dart-lang/web/actions/workflows/web.yaml/badge.svg)](https://github.com/dart-lang/web/actions/workflows/web.yaml)

Conversation

kevmoo commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 15, 2026

Uh oh!

kevmoo commented Apr 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

nikeokoronkwo commented Apr 15, 2026

Uh oh!

kevmoo commented Apr 15, 2026

Uh oh!

srujzs commented Apr 15, 2026

Uh oh!

kevmoo commented Apr 15, 2026

Uh oh!

kevmoo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

srujzs commented Apr 15, 2026

Uh oh!

kevmoo commented Apr 15, 2026

Uh oh!

Uh oh!

nikeokoronkwo Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

srujzs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 18, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 18, 2026

Uh oh!

kevmoo commented Apr 18, 2026

Uh oh!

srujzs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

kevmoo commented Apr 14, 2026 •

edited

Loading