Skip to content

allow build_runner args to the build command #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakemac53 merged 1 commit into from
Apr 18, 2019
Merged

allow build_runner args to the build command #303

jakemac53 merged 1 commit into from
Apr 18, 2019

Conversation

@jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Apr 18, 2019

This is necessary for providing --delete-conflicting-outputs at a minimum.

@jakemac53 jakemac53 requested a review from natebosch April 18, 2019 21:57
@jakemac53
Copy link
Contributor Author

jakemac53 commented Apr 18, 2019

Note that serve also already supports this, so this just brings them in sync

@jakemac53 jakemac53 merged commit f44cc33 into master Apr 18, 2019
@jakemac53 jakemac53 deleted the build_runner_args branch April 18, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natebosch natebosch Awaiting requested review from natebosch

1 more reviewer

@grouma grouma grouma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakemac53 @grouma