Skip to content

allow build_runner args to the build command #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakemac53 merged 1 commit into from
Apr 18, 2019
Merged

allow build_runner args to the build command #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions webdev/lib/src/command/build_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,22 @@ class BuildCommand extends Command<int> {

@override
Future<int> run() async {
if (argResults.rest.isNotEmpty) {
var unsupported =
argResults.rest.where((arg) => !arg.startsWith('-')).toList();
if (unsupported.isNotEmpty) {
throw UsageException(
'Arguments were provided that are not supported: '
'"${argResults.rest.join(' ')}".',
'"${unsupported.join(' ')}".',
argParser.usage);
}
var extraArgs =
argResults.rest.where((arg) => arg.startsWith('-')).toList();

var configuration = Configuration.fromArgs(argResults);
setVerbosity(configuration.verbose);
var pubspecLock = await readPubspecLock(configuration);
final arguments = buildRunnerArgs(pubspecLock, configuration);
final arguments = buildRunnerArgs(pubspecLock, configuration)
..addAll(extraArgs);

try {
logHandler(Level.INFO, 'Connecting to the build daemon...');
Expand Down
15 changes: 15 additions & 0 deletions webdev/test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,21 @@ void main() {
await process.shouldExit(isNot(0));
});

test('build should allow passing extra arguments to build_runner', () async {
var args = [
'build',
'-o',
'web:${d.sandbox}',
'--',
'--delete-conflicting-outputs'
];

var process = await runWebDev(args, workingDirectory: exampleDirectory);

await checkProcessStdout(process, ['Succeeded']);
await process.shouldExit(0);
});

group('should build with valid configuration', () {
for (var withDDC in [true, false]) {
test(withDDC ? 'DDC' : 'dart2js', () async {
Expand Down