fix(colours): letter-family group boxes lost their palette colours (uppercase distinctly coloured again)

[willwade]

Summary

Fixes #62 — the v5-parity report: "In v5, [capitals] were placed in a separate, uniquely colored node, which made them much easier to spot and target quickly." The separate group node survived; its colour did not.

Investigation traced it with a frame-command colour probe (scan dasher_frame output for filled-rect RGB per palette), which found two compounding causes:

1. Load-order clobber (hits every default-palette user)

DasherInterfaceBase parsed new-format color.*.xml before legacy colour.*.xml — and Data/colours/colour.xml is a legacy palette also named "Default". ParseLegacy overwrote KnownPalettes["Default"], destroying the new-format Default that defines uppercase groupColor="#ffff00". Probe, pre-fix: on Default no group box rendered with any palette fill at all; on European/Asian the yellow uppercase box rendered fine.

2. Legacy parser never set letter-family group colours

ParseLegacy mapped every letter-family colorInfoName to one shared GroupColorInfo with no groupColor, and its key list missed the bare "uppercase" / "limitedPunctuation" names the alphabet files actually use — so legacy palettes rendered all letter families identically.

Fix

• Legacy files parse first; the maintained new format wins name collisions.
• ParseLegacy restores group colours per v6's palette design: lowercase 0 / uppercase 111 (yellow) / punctuation 112 (green) / numbers 113 (red) — legacy indices that exactly match the new-format files' groupColor values (verified against the parsed palettes; v5's own file had pink there, but v6's maintained palettes deliberately chose yellow/green/red, so the fix makes both formats consistent).

Result (probe-verified)

palette	uppercase group box
Default	none → #FFFF00
European/Asian (Original) (legacy)	none → #FFFF00
European/Asian (new)	#FFFF00 (unchanged)

Capitals now sit in a distinctly coloured group box on every palette — the v5 behaviour restored under v6's colour design.

Test

uppercase_group_box_has_distinct_colour (test_draw_commands.cpp): renders frames and asserts the uppercase group's fill colour on both the Default palette (post-clobber) and a legacy palette — verified failing pre-fix, passing post-fix. Local matrix suite green (capi 10, extended 17, draw 9, parameters 13, settings 7, color-math 14).

Fixes #62

Greptile Summary

The PR restores distinct letter-family group-box colors across modern and legacy palettes and ensures maintained modern palettes win name collisions.

• Loads legacy colour.*.xml files before modern color.*.xml files.
• Assigns legacy group colors for lowercase, uppercase, punctuation, and number families.
• Adds regression coverage for uppercase group coloring in both default and legacy palettes.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/DasherCore/ColorIO.cpp	Adds distinct legacy group-box colors and aliases for the letter-family names used by alphabet definitions.
src/DasherCore/DasherInterfaceBase.cpp	Reorders palette discovery so maintained modern definitions override colliding legacy palette names.
tests/test_draw_commands.cpp	Adds command-stream regression coverage tying the expected uppercase color to the geometry containing the capital “A” label.

_{Reviews (2): Last reviewed commit: "test: tie uppercase-box assertion to geo..." | Re-trigger Greptile}