Skip to content

backport namespace changes in support of newer bind and boost libraries #4340

@taw00

Description

@taw00

I have had to patch dash core for a while now for my builds in order to successfully build with newer boost and bind. Specifically, this patch:
https://github.com/taw00/dashcore-rpm/blob/master/SOURCES/dash-0.17.0.3-patch02-bind-namespace-errors.patch

Now, bitcoin upstream fixed this some time ago, but they also shifted to std::bind or some such. I.e., their fix is different than my fix, and therefore, I was not going to commit a PR to the dashcore codebase. This really needs someone more intimate with the code to do it right. It alters a bunch of method calls so ... I leave it in y'all's good hands. :)

Here's an example of what bitcoin upstream did to address some of the namespacing issues. I don't know if this was the only change.
bitcoin@cb53b82

It would be really nice if for the next major release we addressed this.

Thanks! -t

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions