refactor: remove return value from InitAutoBackup follow-up #3426

[knst]

Issue being fixed or feature implemented

InitAutoBackup always return true since #3426.

What was done?

Refactored to return no value

How Has This Been Tested?

Build and run

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[coderabbitai]

Walkthrough

The changes update the InitAutoBackup method across several components by changing its return type from bool to void. This modification is applied in the interface (WalletInitInterface), its implementations (in classes such as DummyWalletInit, WalletInit, and CWallet), and the corresponding header declarations. In addition, the removal of the return statements in the method implementations eliminates the previous feedback mechanism that indicated a successful or failed backup initialization. The alteration also involves updating the calling code in src/init.cpp, where the previous conditional check based on the returned boolean value has been removed. Overall, these updates standardize the method signature for auto backup initialization and change its behavior by not returning any status indication.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 794d346 and c2e4420.

📒 Files selected for processing (6)

• src/dummywallet.cpp (1 hunks)
• src/init.cpp (1 hunks)
• src/wallet/init.cpp (2 hunks)
• src/wallet/wallet.cpp (1 hunks)
• src/wallet/wallet.h (1 hunks)
• src/walletinitinterface.h (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: mac-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: linux64_multiprocess-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: win64-build / Build source
• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64_ubsan-build / Build source

🔇 Additional comments (7)

src/wallet/wallet.h (1)

928-928: Method signature changed from returning bool to void

The return type of InitAutoBackup() has been changed from bool to void, which simplifies the interface by removing a return value that was no longer being utilized. This aligns with the PR objective of eliminating a return value that was consistently returning true since PR #3426.

src/dummywallet.cpp (1)

34-34: Method signature updated to match interface change

The InitAutoBackup() method in DummyWalletInit has been properly updated to match the interface change, with the return type changed from bool to void and the return statement removed. This is a consistent implementation of the interface change across the codebase.

src/wallet/wallet.cpp (1)

3745-3752: Approved: Return type changed from bool to void as planned

The function signature has been changed from returning a boolean to void, and the early return statement has been simplified accordingly. This is in line with the PR objective to remove the unused return value.

src/walletinitinterface.h (1)

31-31: Return type changed from bool to void.

This change removes the boolean return value from InitAutoBackup() method, aligning with the PR objective to eliminate the return value as it was consistently returning true since PR #3426.

src/init.cpp (1)

1554-1554: Removed conditional return check for InitAutoBackup.

The function call no longer checks for a return value since the method signature has been changed from returning bool to void. This simplifies the code flow by removing an unnecessary condition check that was always evaluating to true since PR #3426.

src/wallet/init.cpp (2)

52-52: The function signature update looks good.

The change from bool to void return type aligns with the PR objective to eliminate the return value, which was consistently returning true as mentioned in the PR description.

---

234-237: Implementation successfully updated to remove the return value.

The method implementation has been correctly modified to simply call CWallet::InitAutoBackup() without returning any value, which matches the updated function signature in the interface. This change successfully accomplishes the refactoring goal described in the PR.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[UdjinM6]

utACK c2e4420

[PastaPastaPasta]

utACK c2e4420