chore: sync formating of wallet/rpc code with Bitcoin Core#7130
chore: sync formating of wallet/rpc code with Bitcoin Core#7130PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
It helps to make backports significantly! mostly whitespaces, but changed order of 2 strings in one particular case for RPC importmulti This PR is a follow-up for missing changes from bitcoin#17809 and other PRs
|
WalkthroughThis PR restructures RPC help definitions and schemas across the wallet subsystem (addresses, backup, coins, encrypt, spend, transactions, and wallet RPC handlers). The changes reorganize RPCHelpMan declarations to provide more explicit argument definitions, expand result schemas with detailed field specifications, and reformat help text for consistency. No functional logic or runtime behavior is modified—the core RPC implementations remain unchanged. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ith Bitcoin Core 1a49e0f refactor: change function order to unify with Bitcoin Core in rpc/node (Konstantin Akimov) 1bde72a fmt: unify formatting for RPC code with Bitcoin Core (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions. ## What was done? Manually sync formatting with rpc/ code (exclude wallet) Bitcoin Core v25.99 (commit bbbf89a) See also: #7130 These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size. Hint: use 'ignore whitespace' feature to review this PR. ## How Has This Been Tested? On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 1a49e0f Tree-SHA512: c9848090c85f968453d667db60c910312dc76e2eba601551c60b388531de18a57ecbe30769c4fe1f218c36e83423a24ae1e219bc20f2ecb6f01b5f46e0d90ab9
Issue being fixed or feature implemented
Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions.
What was done?
Manually sync formatting for wallet/rpc with Bitcoin Core v25.99 (commit bbbf89a)
See also: #7129
These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size.
Hint: use 'ignore whitespace' feature to review this PR.
How Has This Been Tested?
On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts.
Breaking Changes
N/A
Checklist: