backport: Merge bitcoin#29227, (partial) 27389, 27832, 30215

[vijaydasmp]

bitcoin backporting

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[coderabbitai]

Walkthrough

This pull request updates JSON-RPC examples and generated help to use Content-Type: application/json instead of text/plain (docs, rpc util, and RPC help tests). The -datacarriersize CLI help text was rewritten for clarity only. Mempool dump loading in validation.cpp was refactored to iterate with an explicit tried counter and to emit periodic progress logs at 10% granularity. Functional tests were adjusted: binary /getutxos request/response handling moved from struct/BytesIO to explicit byte operations, and the mempool datacarrier functional test was expanded to four nodes, added scenarios for null/zero/one-byte OP_RETURN payloads, and relaxed a test method's parameter typing.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description 'bitcoin backporting' is vague and generic, providing no meaningful information about what is being backported or why.	Expand the description to explain which upstream changes are being merged and their purpose, e.g., 'Backport of bitcoin#29227, #27389, #27832, #30215 for improved mempool logging, test refactoring, and RPC documentation updates.'

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately identifies this as a backport of four Bitcoin PRs and lists them by number, clearly conveying the main change.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (3)

src/rpc/util.cpp (1)

222-234: Port number inconsistency between HelpExampleRpc and HelpExampleRpcNamed.

HelpExampleRpc on line 223 uses port 9998 (Dash mainnet RPC), while HelpExampleRpcNamed on line 234 uses port 8332 (Bitcoin mainnet RPC). This inconsistency appears to predate this PR but is worth noting since this code is being modified.

The content-type change from text/plain to application/json is correct for JSON-RPC requests.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/rpc/util.cpp` around lines 222 - 234, The two example helpers use
different hard-coded ports—HelpExampleRpc uses 9998 while HelpExampleRpcNamed
uses 8332—so make them consistent: either replace the 9998 in HelpExampleRpc
with 8332 to match HelpExampleRpcNamed, or (preferred) use the shared RPC port
constant/variable used elsewhere (instead of a literal) in both HelpExampleRpc
and HelpExampleRpcNamed so both examples always show the correct configured RPC
port.

test/functional/mempool_datacarrier.py (2)

33-36: Consider using list unpacking for cleaner syntax.

The type hint was removed to accommodate None, and the concatenation works correctly. However, using unpacking is more idiomatic Python.

Proposed changes

-    def test_null_data_transaction(self, node: TestNode, data, success: bool) -> None:
+    def test_null_data_transaction(self, node: TestNode, data: bytes | None, success: bool) -> None:
         tx = self.wallet.create_self_transfer(fee_rate=0)["tx"]
         data = [] if data is None else [data]
-        tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN] + data)))
+        tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN, *data])))

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` around lines 33 - 36, The
test_null_data_transaction function currently builds the OP_RETURN script by
concatenating a list ([OP_RETURN] + data) after normalizing data to a list;
replace that concatenation with Python list unpacking to be more idiomatic: keep
the data normalization (data = [] if data is None else [data]) and construct the
CScript using CScript([OP_RETURN, *data]) when creating the CTxOut (refer to
test_null_data_transaction, tx.vout.append(CTxOut(...)), CScript and data
variables).

---

30-30: Remove extraneous f-string prefix.

This string has no placeholders, so the f prefix is unnecessary.

Proposed fix

-            ["-datacarrier=1", f"-datacarriersize=2"],
+            ["-datacarrier=1", "-datacarriersize=2"],

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` at line 30, The second list element
uses an unnecessary f-string (f"-datacarriersize=2") even though there are no
placeholders; replace f"-datacarriersize=2" with a plain string
"-datacarriersize=2" in the list (e.g., change ["-datacarrier=1",
f"-datacarriersize=2"] to ["-datacarrier=1", "-datacarriersize=2"]).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/rpc/util.cpp`:
- Around line 222-234: The two example helpers use different hard-coded
ports—HelpExampleRpc uses 9998 while HelpExampleRpcNamed uses 8332—so make them
consistent: either replace the 9998 in HelpExampleRpc with 8332 to match
HelpExampleRpcNamed, or (preferred) use the shared RPC port constant/variable
used elsewhere (instead of a literal) in both HelpExampleRpc and
HelpExampleRpcNamed so both examples always show the correct configured RPC
port.

In `@test/functional/mempool_datacarrier.py`:
- Around line 33-36: The test_null_data_transaction function currently builds
the OP_RETURN script by concatenating a list ([OP_RETURN] + data) after
normalizing data to a list; replace that concatenation with Python list
unpacking to be more idiomatic: keep the data normalization (data = [] if data
is None else [data]) and construct the CScript using CScript([OP_RETURN, *data])
when creating the CTxOut (refer to test_null_data_transaction,
tx.vout.append(CTxOut(...)), CScript and data variables).
- Line 30: The second list element uses an unnecessary f-string
(f"-datacarriersize=2") even though there are no placeholders; replace
f"-datacarriersize=2" with a plain string "-datacarriersize=2" in the list
(e.g., change ["-datacarrier=1", f"-datacarriersize=2"] to ["-datacarrier=1",
"-datacarriersize=2"]).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0120a33b-a7ca-4afc-a648-f0a6b9fa389c

📥 Commits

Reviewing files that changed from the base of the PR and between af926ae and 00f1792.

📒 Files selected for processing (7)

• doc/JSON-RPC-interface.md
• src/init.cpp
• src/rpc/util.cpp
• src/test/rpc_tests.cpp
• src/validation.cpp
• test/functional/interface_rest.py
• test/functional/mempool_datacarrier.py

[UdjinM6]

utACK 00f1792

[knst]

27389: should be marked as partial

[knst]

lgtm overal; 27389 should be marked as partial

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/functional/mempool_datacarrier.py`:
- Line 30: Remove the unnecessary f-string prefix from the datacarriersize
argument: change the list element f"-datacarriersize=2" to a plain string
"-datacarriersize=2" in the array that currently contains ["-datacarrier=1",
f"-datacarriersize=2"] so the code no longer triggers the F541 unused f-string
warning.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4f25b02a-da23-4af2-bfab-5ec9225cb8f7

📥 Commits

Reviewing files that changed from the base of the PR and between 00f1792 and 73e7bf5.

📒 Files selected for processing (7)

• doc/JSON-RPC-interface.md
• src/init.cpp
• src/rpc/util.cpp
• src/test/rpc_tests.cpp
• src/validation.cpp
• test/functional/interface_rest.py
• test/functional/mempool_datacarrier.py

✅ Files skipped from review due to trivial changes (4)

• doc/JSON-RPC-interface.md
• src/rpc/util.cpp
• src/test/rpc_tests.cpp
• src/init.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/validation.cpp

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Expect one hit before the fix and no output after the fix.
python - <<'PY'
import ast
from pathlib import Path

path = Path("test/functional/mempool_datacarrier.py")
tree = ast.parse(path.read_text())
for node in ast.walk(tree):
    if isinstance(node, ast.JoinedStr) and not any(isinstance(v, ast.FormattedValue) for v in node.values):
        print(f"{path}:{node.lineno}: placeholder-free f-string")
PY

Repository: dashpay/dash

Length of output: 124

---

Remove the unused f prefix on line 30.

This f-string has no placeholders and triggers Ruff/Flake8 F541.

Suggested fix

-            ["-datacarrier=1", f"-datacarriersize=2"],
+            ["-datacarrier=1", "-datacarriersize=2"],

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	["-datacarrier=1", f"-datacarriersize=2"],
	["-datacarrier=1", "-datacarriersize=2"],

🧰 Tools

🪛 Flake8 (7.3.0)

[error] 30-30: f-string is missing placeholders

(F541)

🪛 Ruff (0.15.6)

[error] 30-30: f-string without any placeholders

Remove extraneous f prefix

(F541)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` at line 30, Remove the unnecessary
f-string prefix from the datacarriersize argument: change the list element
f"-datacarriersize=2" to a plain string "-datacarriersize=2" in the array that
currently contains ["-datacarrier=1", f"-datacarriersize=2"] so the code no
longer triggers the F541 unused f-string warning.