Skip to content

ci: Revert 26912 backport#7231

Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:revert_26912_bp
Mar 16, 2026
Merged

ci: Revert 26912 backport#7231
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:revert_26912_bp

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Mar 16, 2026

Issue being fixed or feature implemented

Logs in CI are kind of broken now - takes quite some time to load it, shows ~40k top (useless) lines and This step has been truncated due to its large size. View the raw logs from the menu once the workflow run has completed., see https://github.com/dashpay/dash/actions/runs/23136104759/job/67204945809?pr=7229

What was done?

Revert 26912 backport introduced via #7090

How Has This Been Tested?

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 24 milestone Mar 16, 2026
@github-actions
Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@github-actions
Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9a4d8b01-eae0-4504-9bf3-718d0eee55c9

📥 Commits

Reviewing files that changed from the base of the PR and between 32fa1a8 and d2754ae.

📒 Files selected for processing (1)
  • ci/dash/test_integrationtests.sh

Walkthrough

A single parameter value in the test integration script is adjusted, reducing the combined logs length limit passed to test_runner from 99999999 to 4000 characters. No other behavioral changes, logic modifications, or control flow alterations are present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately references the specific commit/PR being reverted (26912 backport via #7090) and directly relates to the single-line change reducing log output, making it clear and specific.
Description check ✅ Passed The description is well-related to the changeset, explaining the problem with oversized CI logs and identifying the revert target, though it lacks details on testing and has all checklist items unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Copy link
Copy Markdown

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Clean and correct single-line CI revert. Restores --combinedlogslen from 99999999 (introduced by bitcoin#26912 backport in #7090) back to the Dash-established value of 4000. The massive log length was causing GitHub Actions to truncate step output and display ~40k useless lines. Full test logs remain available as CI artifacts (the same script collects combined and individual debug logs into testlogs/), so reducing console output length loses no diagnostic information.

Reviewed commit: d2754ae

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d2754ae

@PastaPastaPasta PastaPastaPasta merged commit 9985e10 into dashpay:develop Mar 16, 2026
42 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants