ci: Revert 26912 backport#7231
Conversation
…rmittent issues" This reverts commit 06f3ffe.
|
This pull request has conflicts, please rebase. |
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single parameter value in the test integration script is adjusted, reducing the combined logs length limit passed to test_runner from 99999999 to 4000 characters. No other behavioral changes, logic modifications, or control flow alterations are present. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Clean and correct single-line CI revert. Restores --combinedlogslen from 99999999 (introduced by bitcoin#26912 backport in #7090) back to the Dash-established value of 4000. The massive log length was causing GitHub Actions to truncate step output and display ~40k useless lines. Full test logs remain available as CI artifacts (the same script collects combined and individual debug logs into testlogs/), so reducing console output length loses no diagnostic information.
Reviewed commit: d2754ae
Issue being fixed or feature implemented
Logs in CI are kind of broken now - takes quite some time to load it, shows ~40k top (useless) lines and
This step has been truncated due to its large size. View the raw logs from the menu once the workflow run has completed., see https://github.com/dashpay/dash/actions/runs/23136104759/job/67204945809?pr=7229What was done?
Revert 26912 backport introduced via #7090
How Has This Been Tested?
Breaking Changes
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.