docs(core): fix PoSe score increase to 66% (#584) - #585
Conversation
The PoSe Score Calculation table stated the per-failure increase as Maximum PoSe Score * 2/3 (3333) while the prose on the same page said 66%. The implementation uses an integer 66% (CalcPenalty(66) => max * 66 / 100), so the table was wrong. Correct the table to 66% (3300), recompute the worked-example running scores, and add a note that the on-chain penalty is capped at the maximum PoSe score.
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PoSe documentation now uses a 66% score increase and a 3300-point penalty for a 5000-node example. It recalculates the payment-cycle scores and explains that stored penalties are capped at the maximum score after a ban. ChangesPoSe score documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/core/guide/dash-features-proof-of-service.md`:
- Around line 60-62: Update the note near the PoSe score table to explicitly
state that both displayed 6201 values—DKG Failure (4) and the end of Payment
Cycle 2—are raw arithmetic sums, while the on-chain stored penalty is capped at
the maximum score of 5000.
- Line 45: Clarify the DKG failure reference in the described second 5000-block
cycle by identifying it as the second DKG failure in Payment Cycle 2, or
labeling it DKG Failure (4), while preserving the existing explanation of the
PoSe score and ban.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 69c9dae8-6917-4b6d-8db4-4ca50c763383
📒 Files selected for processing (1)
docs/core/guide/dash-features-proof-of-service.md
Address CodeRabbit review on dashpay#585: disambiguate the cycle-2 failure as DKG Failure (4) (the second failure of the cycle), and note that both displayed 6201 values are raw arithmetic while the on-chain penalty is capped at the maximum.
The PoSe Score Calculation table stated the per-failure increase as Maximum PoSe Score * 2/3 (3333) while the prose on the same page said 66%. The implementation uses an integer 66% (CalcPenalty(66) => max * 66 / 100), so the table was wrong.
Correct the table to 66% (3300), recompute the worked-example running scores, and add a note that the on-chain penalty is capped at the maximum PoSe score.
Closes #584
Summary by CodeRabbit
Preview build: https://dash-docs--585.org.readthedocs.build/en/585/