test(dashnote): wait for note title to render before asserting

[thephez]

The mobile auto-select test waited only for mockListMyNotes to be called, not for the resolved promise's state update to flush, so CI occasionally hit getByText while the loading spinner was still visible. Wait on the rendered title instead.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Summary by CodeRabbit

• Tests
  • Updated test timing assertions for improved test reliability.

Note: This is an internal test improvement with no end-user facing changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 051f27cc-8a5b-4eb1-8680-b08d0c2c8f55

📥 Commits

Reviewing files that changed from the base of the PR and between 8be479d and 95653c9.

📒 Files selected for processing (1)

• example-apps/dashnote/test/NotesWorkspace.test.tsx

---

📝 Walkthrough

Walkthrough

The PR updates a single test assertion in the mobile notes workspace test. The "phone note" title expectation is moved inside the waitFor block to enforce strict timing, ensuring the assertion waits for the asynchronous render before validating.

Changes

Mobile test assertion timing

Layer / File(s)	Summary
Mobile note selection test timing fix example-apps/dashnote/test/NotesWorkspace.test.tsx	The assertion validating the "phone note" title is rendered moves into the await waitFor(...) block, tightening timing while preserving all other test validations around editor visibility and mockGetNote behavior.

Poem

🐰 A timing tweak, so small yet keen,
Assertions wait for renders seen,
The waitFor wraps with gentle care,
Test flow fixed, now rock-solid there! ✨

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly summarizes the main change: updating a test to wait for the note title to render before asserting, which matches the file modification described in the raw summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/fix-failing-ci-test

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

example-apps/dashnote/test/NotesWorkspace.test.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0