Skip to content

test(dashnote): wait for note title to render before asserting #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thephez merged 1 commit into from
May 28, 2026
Merged

test(dashnote): wait for note title to render before asserting #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example-apps/dashnote/test/NotesWorkspace.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,11 +650,11 @@ describe("NotesWorkspace", () => {
render(<NotesWorkspace onOpenLogin={vi.fn()} onOpenSettings={vi.fn()} />);

await waitFor(() => {
expect(mockListMyNotes).toHaveBeenCalledTimes(1);
expect(screen.getByText(/phone note/i)).toBeTruthy();
});
// List rendered (note title visible) but editor body field not, since
// no note has been selected yet on mobile.
expect(screen.getByText(/phone note/i)).toBeTruthy();
expect(mockListMyNotes).toHaveBeenCalledTimes(1);
expect(mockGetNote).not.toHaveBeenCalled();
expect(screen.queryByLabelText(/^body$/i)).toBeNull();
});
Expand Down