fix(sdk): centralize mainnet and testnet bootstrap builders#3530
Closed
fix(sdk): centralize mainnet and testnet bootstrap builders#3530
Conversation
Agent-Logs-Url: https://github.com/dashpay/platform/sessions/792a6a35-3c58-465b-91a3-31122aaf67e5 Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dashpay/platform/sessions/792a6a35-3c58-465b-91a3-31122aaf67e5 Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Integrate rust-dashcore masternode list into dash-sdk
fix(sdk): centralize mainnet and testnet bootstrap builders
Apr 24, 2026
6 tasks
Collaborator
|
Superseded by #3533 — same structure (centralize into 🤖 Co-authored by Claudius the Magnificent AI Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK still left
SdkBuilder::new_mainnet()/new_testnet()unimplemented, while WASM and FFI maintained separate hardcoded Platform gateway lists. This change makesdash-sdkthe single bootstrap source for mainnet/testnet construction and routes dependent layers through it.Shared SDK bootstrap
SdkBuilder::new_mainnet()andSdkBuilder::new_testnet()inpackages/rs-sdk/src/sdk.rsdash-sdkparse_address_list()/default_address_list_for_network()Consumer cleanup
packages/wasm-sdk/src/sdk.rsto callSdkBuilder::new_mainnet()/SdkBuilder::new_testnet()instead of carrying its own gateway listspackages/rs-sdk-ffi/src/sdk.rsto use the shared SDK constructors instead of rebuilding address lists locallyCoverage
packages/rs-sdk/src/sdk.rsasserting that:new_mainnet()setsNetwork::Mainnetand the expected bootstrap setnew_testnet()setsNetwork::Testnetand the expected bootstrap setWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https s-a90a27f5881aed-m64 s-a90a27f5881aed/tmp/rustctk7pgV/symbols.o "ffi-testing", "jni", "once_cell")) s-a9�� s-a90a27f5881aed-Wl,--as-needed s-a90a27f5881aed-Wl,-Bstatic n/rustc s-a90a27f5881aedgit s-a90a27f5881aedpush s-a90a27f5881aed-v n/rustc s-a9�� s-a90a27f5881aed/home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64cargo-fmt s-a90a27f5881aed/home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64fmt f/ureq-3.3.0/src/lib.rs /index.crates.iodebian-sa1 /index.crates.io1 /index.crates.io1 -1949cf8c6b5b557/home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libadler2-1e0b0d62df36c85c.rlib(dns block)If you need me to access, download, or install something from one of these locations, you can either: