build: bump rust-dashcore to v0.42-dev 0093278#3532
build: bump rust-dashcore to v0.42-dev 0093278#3532
Conversation
Pull in 37 upstream commits from dashpay/rust-dashcore v0.42-dev, including the dash-network crate extraction, WalletType WatchOnly unit-variant refactor, and the removal of WalletInfoInterface's get_spendable_utxos (moved to account level). Breaking changes that hit the platform build: - key-wallet: WatchOnly is now a unit variant (no more xpub payload). Updated the contact_requests.rs test helper accordingly. - key-wallet: get_spendable_utxos dropped from WalletInfoInterface. Removed the matching impl on PlatformWalletInfo — no platform callers. - key-wallet-ffi: FFINetwork is no longer re-exported; it now lives in the new dash-network crate under the "ffi" feature. Added dash-network as a workspace dep and repointed imports in rs-platform-wallet-ffi. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔍 Review in progress — actively reviewing now (commit a7e3000) |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
I verified commit a7e300078e4bb2d53c4f0c8aada983cd7d3c4954 against the source and diff. The change removes only a two-line comment from the #[cfg(test)] helper create_dummy_wallet in packages/rs-platform-wallet/src/platform_wallet_info/contact_requests.rs; the executable code at line 486 is unchanged, and there are no consensus, correctness, or test-behavior implications.
Reviewed commit: a7e3000
Issue being fixed or feature implemented
Refresh our
dashpay/rust-dashcorepin to the latestv0.42-devHEAD (37 commits ahead of the previous pin,88e8a9aa). Keeps platform aligned with ongoing key-wallet / dash-spv work and picks up several SPV, key-wallet, and FFI fixes that other clients are already consuming.What was done?
Workspace bump from
rev = 88e8a9aa1eadce79c8177f757f6741f8a55a83f5torev = 0093278609a22fc53086bfef569b74bf10544982for:dashcore,dash-spv,dash-spv-ffikey-wallet,key-wallet-ffi,key-wallet-managerdashcore-rpcAdded
dash-network(new standalone crate extracted fromdashcoreupstream in PR dashpay/rust-dashcore#679) to[workspace.dependencies], pinned to the same rev and required byrs-platform-wallet-ffiforFFINetwork(now behind theffifeature ofdash-networkrather than re-exported fromkey-wallet-ffi).Breaking changes from upstream that actually hit this codebase:
WalletType::WatchOnlyis now a unit variant (refactor(key-wallet): make WatchOnly / ExternalSignable unit variants rust-dashcore#654). Updated thecreate_dummy_wallettest helper inrs-platform-wallet/src/platform_wallet_info/contact_requests.rs— dropped the xpub payload and removed the now-unusedExtendedPubKeyimport.WalletInfoInterface::get_spendable_utxosremoved (refactor(key-wallet): move spendable_utxos from wallet to account rust-dashcore#643, moved to account level). Dropped the matching impl stub onPlatformWalletInfo— no other platform callers.FFINetworkrelocated (refactor: dashcore exposes a FFI compatible Network enum so dependents don't have to make their own wrapper rust-dashcore#642, feat: withdrawals status sync #679). Addeddash-networkas a workspace dep withfeatures = ["ffi"]inrs-platform-wallet-ffiand repointed two imports todash_network::ffi::FFINetwork.Other upstream refactors (
FFIExtendedPriv/PubKeyrenames, newFFIError, AssetLockTx DIP-00X fix,Address<NetworkChecked>serde fix) did not surface in the platform build — those APIs aren't referenced here.How Has This Been Tested?
cargo check --workspace --all-targets— passcargo test --workspace --no-run— all test binaries compilecargo fmt --all --check— cleancargo clippy --workspace --all-targets -- -D warnings— same pre-existing warnings asv3.1-devHEAD inrs-platform-value/rs-platform-serialization; not introduced by this bumpThe full runtime test suite (
yarn test) needs a running local node and was not executed. Recommend running it before merge.Breaking Changes
None for platform consumers. All API shifts are internal (workspace-local dependency rev + the three call-site adjustments listed above).
Checklist:
For repository code-owners and collaborators only
🤖 Co-authored by Claudius the Magnificent AI Agent