Skip to content

chore: merge v3.1-dev into PR 3485#3597

Merged
PastaPastaPasta merged 1 commit intodashpay:fix/wasm-sdk-testnet-addressesfrom
thepastaclaw:merge-v3.1-dev-into-pr3485
May 5, 2026
Merged

chore: merge v3.1-dev into PR 3485#3597
PastaPastaPasta merged 1 commit intodashpay:fix/wasm-sdk-testnet-addressesfrom
thepastaclaw:merge-v3.1-dev-into-pr3485

Conversation

@thepastaclaw
Copy link
Copy Markdown
Collaborator

Merge v3.1-dev into PR 3485

Issue being fixed or feature implemented

Follow-up to #3485. This merges current v3.1-dev into
the PR branch so the original PR can be reviewed against the latest base.

What was done

  • Merged origin/v3.1-dev into fix/wasm-sdk-testnet-addresses on branch
    merge-v3.1-dev-into-pr3485.
  • Resolved conflicts in the Rust SDK, Rust SDK FFI, and WASM SDK builder code.
  • Kept the PR-side trusted FFI logging while preserving v3.1-dev seed-backed
    mainnet/testnet address defaults.
  • Kept the WASM local builder working after SdkBuilder::new_local() was
    removed from the Rust SDK base branch.

How Has This Been Tested

See ## Validation below.

Validation

  • Conflict-marker grep across the three previously conflicted SDK files — no
    conflict markers found.
  • git diff --check origin/v3.1-dev..HEAD — passed for the PR-specific delta.
  • cargo check -p dash-sdk -p rs-sdk-ffi -p wasm-sdk — passed.
  • cargo check from the pre-commit hook — passed.
  • yarn workspace @dashevo/dapi-grpc lint — blocked by local Node.js v25.9.0
    failing with EBADF: bad file descriptor, fstat; this is reproducible
    outside the hook.
  • code-review dashpay/platform origin/v3.1-dev merge-v3.1-dev-into-pr3485
    with intent PR #3485 after merging v3.1-dev; review only PR-specific delta and conflict resolutions — recommendation: ship.

Breaking Changes

None introduced beyond the current v3.1-dev base being merged into the
existing PR branch.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the
    corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@thepastaclaw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 11 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3bf2f5bc-2e02-4303-bc9d-d0b2c612dc94

📥 Commits

Reviewing files that changed from the base of the PR and between 0c04457 and ca829b4.

📒 Files selected for processing (1)
  • packages/rs-sdk-ffi/src/sdk.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review May 5, 2026 14:55
@PastaPastaPasta PastaPastaPasta merged commit c67cd57 into dashpay:fix/wasm-sdk-testnet-addresses May 5, 2026
4 checks passed
@thepastaclaw
Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants