Skip to content

fix(wallet-lib): validate remote transaction proofs#4157

Merged
QuantumExplorer merged 2 commits into
v4.1-devfrom
codex/fix-wallet-proof-verification
Jul 22, 2026
Merged

fix(wallet-lib): validate remote transaction proofs#4157
QuantumExplorer merged 2 commits into
v4.1-devfrom
codex/fix-wallet-proof-verification

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Summary

  • validate partial Merkle trees before importing or confirming wallet transactions
  • keep pending transaction updates atomic across proof failures
  • require an explicit trusted verifier before exposing InstantLock state
  • correct the shared Merkle proof helper to invoke tree validation

Internal review coverage: 357, 358, 359.

Verification

  • yarn workspace @dashevo/wallet-lib mocha 'src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.spec.js' (43 passing)\n- yarn workspace @dashevo/dash-spv test (56 passing, 3 pending)\n- ESLint on all changed production/test files (no errors)\n\nThe repository-wide wallet unit command additionally requires the generated packages/wasm-dpp/dist artifact, which is not present in the isolated worktree.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0d8c38f-2d3b-4921-a286-8747ad714290

📥 Commits

Reviewing files that changed from the base of the PR and between fc05d62 and 855856f.

📒 Files selected for processing (6)
  • packages/dash-spv/lib/merkleproofs.js
  • packages/js-dash-sdk/src/test/mocks/createAndAttachTransportMocksToClient.ts
  • packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.js
  • packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.spec.js
  • packages/wallet-lib/src/test/mocks/dashcore/block.js
  • packages/wallet-lib/tests/integration/plugins/Workers/TransactionsSyncWorker.spec.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-wallet-proof-verification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 20, 2026
@QuantumExplorer
QuantumExplorer marked this pull request as ready for review July 21, 2026 02:04
@thepastaclaw

thepastaclaw commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

🔍 Review in progress — actively reviewing now (commit 855856f)
Stage: Codex precheck starting
ETA: complete ~17:26 UTC (median 36m across 30 recent reviews)
Running 19m · Last checked: 2026-07-22 17:10 UTC

@QuantumExplorer QuantumExplorer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@QuantumExplorer QuantumExplorer changed the title fix(wallet): validate remote transaction proofs fix(wallet-lib): validate remote transaction proofs Jul 21, 2026
@QuantumExplorer
QuantumExplorer requested a review from shumkov as a code owner July 21, 2026 05:59
@QuantumExplorer
QuantumExplorer merged commit f54cdcb into v4.1-dev Jul 22, 2026
28 of 30 checks passed
@QuantumExplorer
QuantumExplorer deleted the codex/fix-wallet-proof-verification branch July 22, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants