Skip to content

Revert "feat(platform-wallet): add encrypted txMetadata document support" - #4279

Open
QuantumExplorer wants to merge 1 commit into
v4.2-devfrom
revert-4277-codex/txmetadata-index-redesign-v42
Open

Revert "feat(platform-wallet): add encrypted txMetadata document support"#4279
QuantumExplorer wants to merge 1 commit into
v4.2-devfrom
revert-4277-codex/txmetadata-index-redesign-v42

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Aug 4, 2026

Copy link
Copy Markdown
Member

Reverts #4277

Summary by CodeRabbit

  • Breaking Changes
    • Removed support for creating, fetching, encrypting, and decrypting encrypted transaction-metadata documents.
    • Removed related encryption-key handling, payload limits, error reporting, and public API exports.
    • Standard document operations—create, replace, delete, transfer, pricing, and purchase—remain available.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 755fa8f4-b40e-4775-b809-20a7d70698d8

📥 Commits

Reviewing files that changed from the base of the PR and between f53e5ee and e4c31ad.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/documents/DocumentTransactions.kt
  • packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/ffi/TransactionsNative.kt
  • packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/documents/DocumentTransactionsVersionValidationTest.kt
  • packages/rs-platform-wallet-ffi/Cargo.toml
  • packages/rs-platform-wallet-ffi/src/document.rs
  • packages/rs-platform-wallet-ffi/src/error.rs
  • packages/rs-platform-wallet/Cargo.toml
  • packages/rs-platform-wallet/src/error.rs
  • packages/rs-platform-wallet/src/lib.rs
  • packages/rs-platform-wallet/src/wallet/identity/crypto/mod.rs
  • packages/rs-platform-wallet/src/wallet/identity/crypto/tx_metadata.rs
  • packages/rs-platform-wallet/src/wallet/identity/network/encrypted_document.rs
  • packages/rs-platform-wallet/src/wallet/identity/network/mod.rs
  • packages/rs-platform-wallet/tests/legacy_wire_compat/LegacyDerivationPathCheck.java
  • packages/rs-platform-wallet/tests/legacy_wire_compat/LegacyKeyN.java
  • packages/rs-platform-wallet/tests/legacy_wire_compat/README.md
  • packages/rs-platform-wallet/tests/txmetadata_fetch.rs
  • packages/rs-unified-sdk-jni/src/transactions.rs
💤 Files with no reviewable changes (14)
  • packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/documents/DocumentTransactionsVersionValidationTest.kt
  • packages/rs-platform-wallet-ffi/src/error.rs
  • packages/rs-platform-wallet-ffi/Cargo.toml
  • packages/rs-unified-sdk-jni/src/transactions.rs
  • packages/rs-platform-wallet/src/wallet/identity/crypto/mod.rs
  • packages/rs-platform-wallet/src/wallet/identity/network/mod.rs
  • packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/ffi/TransactionsNative.kt
  • packages/rs-platform-wallet/tests/legacy_wire_compat/LegacyDerivationPathCheck.java
  • packages/rs-platform-wallet/tests/legacy_wire_compat/LegacyKeyN.java
  • packages/rs-platform-wallet/src/error.rs
  • packages/rs-platform-wallet/tests/legacy_wire_compat/README.md
  • packages/rs-platform-wallet/tests/txmetadata_fetch.rs
  • packages/rs-platform-wallet/src/wallet/identity/crypto/tx_metadata.rs
  • packages/rs-platform-wallet/src/wallet/identity/network/encrypted_document.rs

📝 Walkthrough

Walkthrough

The change removes encrypted txMetadata document creation, fetching, encryption, decryption, key derivation, native bridges, public exports, and related tests and dependencies across the Rust wallet, FFI, JNI, and Kotlin SDK.

Changes

Encrypted transaction metadata removal

Layer / File(s) Summary
Wallet crypto and network API removal
packages/rs-platform-wallet/src/wallet/identity/..., packages/rs-platform-wallet/src/lib.rs, packages/rs-platform-wallet/Cargo.toml
Removes transaction-metadata cryptography, encrypted-document networking, public re-exports, and related dependency configuration.
FFI and JNI bridge removal
packages/rs-platform-wallet-ffi/..., packages/rs-unified-sdk-jni/src/transactions.rs
Removes encrypted document FFI and JNI operations, payload handling, error mapping, and base64 support.
Kotlin SDK surface removal
packages/kotlin-sdk/sdk/src/main/kotlin/.../documents/DocumentTransactions.kt, packages/kotlin-sdk/sdk/src/main/kotlin/.../ffi/TransactionsNative.kt
Removes encrypted document native declarations and SDK methods. Adds coroutine dispatcher imports.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

  • dashpay/platform#4243: Introduced the encrypted txMetadata functionality removed by this change.
  • dashpay/platform#4264: Added related encrypted document functionality across the Kotlin, JNI, FFI, and Rust wallet APIs.

Suggested reviewers: lklimek, llbartekll, zocolini

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the pull request reverts the encrypted txMetadata document support added by PR #4277.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-4277-codex/txmetadata-index-redesign-v42

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit e4c31ad)

@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 4, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex + Sonnet

The PR is an exact file-for-file revert of #4277 and consistently removes the encrypted txMetadata implementation across Rust, FFI/JNI, Kotlin APIs, dependencies, exports, and tests. No functional or blocking issue remains, but the revert reintroduces two unused Kotlin imports that should be removed as a small cleanup.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — security-auditor (completed), gpt-5.6-sol — rust-quality (completed), gpt-5.6-sol — ffi-engineer (completed)
  • Verifier: gpt-5.6-sol — final-verifier (fallback)
  • Sonnet reviewers: claude-sonnet-5 — general (completed), claude-sonnet-5 — security-auditor (completed), claude-sonnet-5 — rust-quality (completed), claude-sonnet-5 — ffi-engineer (completed)

💬 1 nitpick(s)

Comment on lines +5 to +6
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Unused coroutine imports reintroduced by the revert

This revert re-adds Dispatchers and withContext, but neither symbol is referenced anywhere in the file. They were also unused before #4277—the removed encrypted-document methods did not reference them—so restoring them only creates dead-import IDE and linter noise. Delete both imports.

source: ['claude']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants