Revert "feat(platform-wallet): add encrypted txMetadata document support" - #4279
Revert "feat(platform-wallet): add encrypted txMetadata document support"#4279QuantumExplorer wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
💤 Files with no reviewable changes (14)
📝 WalkthroughWalkthroughThe change removes encrypted ChangesEncrypted transaction metadata removal
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit e4c31ad) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Codex + Sonnet
The PR is an exact file-for-file revert of #4277 and consistently removes the encrypted txMetadata implementation across Rust, FFI/JNI, Kotlin APIs, dependencies, exports, and tests. No functional or blocking issue remains, but the revert reintroduces two unused Kotlin imports that should be removed as a small cleanup.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed),gpt-5.6-sol— security-auditor (completed),gpt-5.6-sol— rust-quality (completed),gpt-5.6-sol— ffi-engineer (completed) - Verifier:
gpt-5.6-sol— final-verifier (fallback) - Sonnet reviewers:
claude-sonnet-5— general (completed),claude-sonnet-5— security-auditor (completed),claude-sonnet-5— rust-quality (completed),claude-sonnet-5— ffi-engineer (completed)
💬 1 nitpick(s)
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.withContext |
There was a problem hiding this comment.
💬 Nitpick: Unused coroutine imports reintroduced by the revert
This revert re-adds Dispatchers and withContext, but neither symbol is referenced anywhere in the file. They were also unused before #4277—the removed encrypted-document methods did not reference them—so restoring them only creates dead-import IDE and linter noise. Delete both imports.
source: ['claude']
Reverts #4277
Summary by CodeRabbit