Skip to content

fix(sdk): separate the deletion-resolution doc from the Returns list - #4498

Merged
PastaPastaPasta merged 1 commit into
v4.2-devfrom
hotfix/rs-sdk-doc-lint
Aug 28, 2026
Merged

fix(sdk): separate the deletion-resolution doc from the Returns list#4498
PastaPastaPasta merged 1 commit into
v4.2-devfrom
hotfix/rs-sdk-doc-lint

Conversation

@shumkov

@shumkov shumkov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

v4.2-dev Tests went red at 4ca678f (Rust workspace / Clippy lints): 7x doc list item without indentation in packages/rs-sdk/src/platform/documents/transitions/delete.rs:168-174, introduced by #4495 — a new doc paragraph glued directly onto the * Result<...> list item. One blank /// line ends the list. cargo clippy -p dash-sdk --lib clean after.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Improved the formatting of the sign method documentation for readability.

Clippy (-D warnings) reads the paragraph glued to the `* Result<...>`
list item as unindented list continuations — 7 doc-lint errors breaking
the v4.2-dev Tests workflow since #4495. A blank doc line ends the list.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7737b7c9-9e11-4017-baeb-1a40b8018a88

📥 Commits

Reviewing files that changed from the base of the PR and between 4ca678f and 4600c32.

📒 Files selected for processing (1)
  • packages/rs-sdk/src/platform/documents/transitions/delete.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Documentation Update

Layer / File(s) Summary
Sign method documentation
packages/rs-sdk/src/platform/documents/transitions/delete.rs
Added a blank /// line between the # Returns section and the resolve_document_for_deletion description. No code behavior changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4600c

This documentation-only formatting fix resolves a Clippy lint without changing SDK behavior or system design, so no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: lklimek, quantumexplorer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the documentation change: it separates the deletion-resolution paragraph from the Returns list to resolve Clippy documentation errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/rs-sdk-doc-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit 4600c32)

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.79%. Comparing base (4ca678f) to head (4600c32).

Additional details and impacted files
@@             Coverage Diff              @@
##           v4.2-dev    #4498      +/-   ##
============================================
+ Coverage     83.00%   83.79%   +0.78%     
============================================
  Files          2744     2773      +29     
  Lines        367956   370833    +2877     
============================================
+ Hits         305411   310726    +5315     
+ Misses        62545    60107    -2438     
Components Coverage Δ
dpp 84.73% <ø> (+0.97%) ⬆️
drive 81.99% <ø> (+0.89%) ⬆️
drive-abci 86.98% <ø> (+1.08%) ⬆️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.92% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 48.41% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex/Sol only (Phase 2 disabled)

At exact head 4600c32, the one-line diff correctly inserts a blank Rustdoc line between the # Returns list and the following paragraph without changing behavior. cargo clippy -p dash-sdk --lib -- -D warnings completed successfully, and no in-scope issues were found. Source: reviewer backend model gpt-5.6-sol; final verifier backend model gpt-5.6-sol; orchestration-only openclaw-agent/cliproxy/gpt-5.6-sol (not reviewer evidence).

Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed)
  • Verifier: gpt-5.6-sol — verifier
  • Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
  • Secondary pass: disabled (temporary_phase2_sonnet_disable)

@PastaPastaPasta
PastaPastaPasta merged commit c747e2f into v4.2-dev Aug 28, 2026
24 checks passed
@PastaPastaPasta
PastaPastaPasta deleted the hotfix/rs-sdk-doc-lint branch August 28, 2026 01:42
QuantumExplorer added a commit that referenced this pull request Aug 28, 2026
Both sides fixed the #4495 doc_lazy_continuation lint in the delete
builder: v4.2-dev's #4498 kept sign()'s Arguments/Returns block above
the extracted helper with a separator line, this branch moved it back
onto sign() itself. Kept this branch's placement — the block documents
sign(), and it already lives there exactly once.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants