test(dashmate): use a sentinel wake-up counter the clock cannot collide with

[shumkov]

v4.2-dev JS packages (dashmate) / Tests is red on the tip: should never claim renewal has been failing since it last succeeded asserts the operator text does not contain "37" (the wake-up counter), but the fixture uses live-clock timestamps and the solution renders minute fields — whenever a rendered time hits :37 the guard false-positives (fails several minutes of every hour). Fix: a 6-digit sentinel counter (739577) that cannot appear in any ISO date/time slice; guard intent unchanged, all clock-relative fixture logic untouched. Spec: 91 passing locally.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated certificate renewal test data to avoid accidental matches with rendered time values.
  • Strengthened counter validation by checking directly that the sentinel value is absent from the description and solution.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: b90c203d-f10e-41a0-aa5f-c06da0a8fe4d

📥 Commits

Reviewing files that changed from the base of the PR and between 96a1033 and 17d66b7.

📒 Files selected for processing (1)

• packages/dashmate/test/unit/doctor/analyse/analyseGatewayCertificateFactory.spec.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The gateway certificate renewal test now uses sentinel failure count 739577. Assertions confirm that this value is absent from rendered descriptions and solutions while renewal messaging remains present.

Changes

Gateway certificate renewal tests

Layer / File(s)	Summary
Sentinel failure count validation packages/dashmate/test/unit/doctor/analyse/analyseGatewayCertificateFactory.spec.js	The fixture uses 739577 to avoid accidental matches with rendered time values. Assertions directly verify that the sentinel value is absent from the description and solution. Renewal messaging checks remain.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 17d66

Gateway certificate renewal tests now use a unique sentinel value, avoiding false failures caused by clock-rendered minute values while preserving coverage that renewal messaging is shown and the failure counter is not.

Suggested reviewers: llbartekll

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main test change: replacing the wake-up counter with a sentinel value that cannot collide with clock output.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hotfix/dashmate-flake

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

🕓 Ready for review — 9 ahead in queue (commit 17d66b7)
Queue position: 10/27 · 2 reviews active
ETA: start ~19:14 UTC · complete ~20:12 UTC (median 57m across 30 recent reviews; 2 slots)
Queued 7h 37m ago · Last checked: 2026-09-07 15:20 UTC

[thepastaclaw]

Final validation — GLM Flash + Sol

The fixture-only change replaces the ambiguous two-digit wake-up counter with a six-digit sentinel that cannot collide with the ISO-derived dates or times rendered by the analyzer, while preserving the counter-leak assertions. The affected Dashmate specification passes all 91 tests, and no in-scope defects were identified.

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-5.6-sol (agent: phase2-reviewer, role: general); final verifier: gpt-5.6-sol (agent: sol-verifier, role: final-verifier)

Review provenance

• Phase 1 reviewers (GLM Flash): glm-5.3-flash — general (completed); agent phase1-reviewer
• Fresh verifier (Sol): gpt-5.6-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers (Sol): gpt-5.6-sol — general (completed); agent phase2-reviewer