Skip to content

test(drive-abci): chained trust-boundary suite — SDK entry points against server proofs - #4568

Merged
QuantumExplorer merged 2 commits into
v4.2-devfrom
test/chained-trust-boundary
Sep 1, 2026
Merged

test(drive-abci): chained trust-boundary suite — SDK entry points against server proofs#4568
QuantumExplorer merged 2 commits into
v4.2-devfrom
test/chained-trust-boundary

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Follow-up to the merged #4552: its codecov/patch showed 0% because the client crates (dash-platform-queries, rs-drive-proof-verifier) sit outside the coverage run's package set — their chained code only counts when exercised from a covered package. This PR adds that exercise, following the exact split the having/ranked families use (having_trust_boundary in the same file): proof generation needs drive's server feature, which the client crates must not enable even as dev-dependencies, so the suite lives server-side.

What was done?

New chained_trust_boundary module in drive-abci's v1 document-query tests, running the real SDK entry points against a server-generated merged proof over the yappr fixture:

  • the rich ChainedDocumentQuery encodes onto the typed V1 wire with the join spec riding along;
  • FromProof<ChainedDocumentQuery> end to end — bootstrap subset pass, re-derived merged verification, and the tenderdash binding of the proof's root to the quorum-signed app hash (test quorum key, canonical precommit construction shared with the having suite's helpers);
  • a wrong quorum key and tampered response metadata are each refused — omitting or miswiring verify_tenderdash_proof turns a test red.

How Has This Been Tested?

The PR is tests: 4/4 green (cargo test -p drive-abci chained_trust_boundary), cargo fmt, no production code touched.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

… against server proofs

Same split as the having/ranked trust-boundary suites: rs-drive's e2e
covers the merk-level composition, and this suite runs the actual SDK
entry points — the dash-platform-queries V1 wire encoding and the
FromProof<ChainedDocumentQuery> composition, including the tenderdash
binding of the merged proof's root — against a real server-generated
proof. A correctly signed root verifies and returns both halves; a
wrong quorum key and tampered response metadata are each refused, so
omitting or miswiring verify_tenderdash_proof turns a test red.

Also the coverage answer for the merged #4552: the client crates are
outside the coverage run's package set, so their chained code counts
only when exercised from drive-abci — which this suite does.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 1, 2026
@thepastaclaw

thepastaclaw commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

🕓 Ready for review — 32 ahead in queue (commit de4d8db)
Queue position: 33/33 · 2 reviews active
ETA: start ~17:43 UTC · complete ~18:47 UTC (median 1h 4m across 30 recent reviews; 2 slots)
Queued 2m ago · Last checked: 2026-09-01 00:30 UTC

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 57 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4515ae2a-5163-487b-b62e-566dd04d1899

📥 Commits

Reviewing files that changed from the base of the PR and between eb70b9f and 2a6864d.

📒 Files selected for processing (1)
  • packages/rs-drive-abci/src/query/document_query/v1/tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.98%. Comparing base (eb70b9f) to head (de4d8db).
⚠️ Report is 1 commits behind head on v4.2-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           v4.2-dev    #4568   +/-   ##
=========================================
  Coverage     86.97%   86.98%           
=========================================
  Files          2786     2786           
  Lines        362680   362753   +73     
=========================================
+ Hits         315435   315532   +97     
+ Misses        47245    47221   -24     
Components Coverage Δ
dpp 88.62% <ø> (ø)
drive 85.71% <ø> (ø)
drive-abci 89.73% <ø> (ø)
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.92% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 41.10% <ø> (+0.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumExplorer
QuantumExplorer merged commit c0e9a86 into v4.2-dev Sep 1, 2026
17 checks passed
@QuantumExplorer
QuantumExplorer deleted the test/chained-trust-boundary branch September 1, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants