test(drive-abci): chained trust-boundary suite — SDK entry points against server proofs - #4568
Conversation
… against server proofs Same split as the having/ranked trust-boundary suites: rs-drive's e2e covers the merk-level composition, and this suite runs the actual SDK entry points — the dash-platform-queries V1 wire encoding and the FromProof<ChainedDocumentQuery> composition, including the tenderdash binding of the merged proof's root — against a real server-generated proof. A correctly signed root verifies and returns both halves; a wrong quorum key and tampered response metadata are each refused, so omitting or miswiring verify_tenderdash_proof turns a test red. Also the coverage answer for the merged #4552: the client crates are outside the coverage run's package set, so their chained code counts only when exercised from drive-abci — which this suite does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🕓 Ready for review — 32 ahead in queue (commit de4d8db) |
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4568 +/- ##
=========================================
Coverage 86.97% 86.98%
=========================================
Files 2786 2786
Lines 362680 362753 +73
=========================================
+ Hits 315435 315532 +97
+ Misses 47245 47221 -24
🚀 New features to boost your workflow:
|
Issue being fixed or feature implemented
Follow-up to the merged #4552: its codecov/patch showed 0% because the client crates (
dash-platform-queries,rs-drive-proof-verifier) sit outside the coverage run's package set — their chained code only counts when exercised from a covered package. This PR adds that exercise, following the exact split the having/ranked families use (having_trust_boundaryin the same file): proof generation needs drive's server feature, which the client crates must not enable even as dev-dependencies, so the suite lives server-side.What was done?
New
chained_trust_boundarymodule in drive-abci's v1 document-query tests, running the real SDK entry points against a server-generated merged proof over the yappr fixture:ChainedDocumentQueryencodes onto the typed V1 wire with the join spec riding along;FromProof<ChainedDocumentQuery>end to end — bootstrap subset pass, re-derived merged verification, and the tenderdash binding of the proof's root to the quorum-signed app hash (test quorum key, canonical precommit construction shared with the having suite's helpers);verify_tenderdash_proofturns a test red.How Has This Been Tested?
The PR is tests: 4/4 green (
cargo test -p drive-abci chained_trust_boundary),cargo fmt, no production code touched.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code