chore: bump grovedb to 6fc7e1e8 (#851 merged: synthesized split bodies keep the inputs' direction) - #4602
Merged
Conversation
…s keep the inputs' direction) Pins grovedb at the develop merge commit of dashpay/grovedb#851. When two branches diverge below a shared key, the merge synthesizes the body at the split; it used to walk ascending whatever the joined bodies did, and since #850 that body can become a merge input during a descent, where its direction is compared with the other inputs'. A descending composition that collides at such a key was refused while its ascending twin merged. The synthesized body now carries the joined bodies' direction. All six `Cargo.toml` pins move together; no platform code change. Composite document queries need this for a descending page combined with a cross-contract lookup and a limited lookup under the page's own contract. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
QuantumExplorer
requested review from
ZocoLini,
lklimek,
llbartekll and
shumkov
as code owners
September 5, 2026 09:21
Contributor
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
Collaborator
|
ℹ️ Review superseded (commit 04fc829) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Composite document queries (#4598, stacked on this PR) merge every component of a page into one grovedb proof. When two branches diverge below a shared key, grovedb's merge synthesizes the body at the split, and until dashpay/grovedb#851 that body walked ascending whatever the joined bodies did. Since #850 such a body can become a merge input during a descent, where its direction is checked against the other inputs', so a descending page combined with a cross-contract lookup and a limited lookup under the page's own contract was refused while the identical ascending composition merged.
What was done?
Pins grovedb at
6fc7e1e8, the develop merge commit of #851, which gives the synthesized body the direction the joined bodies share. All sixCargo.tomlpins move together; no platform code change.How Has This Been Tested?
cargo check -p drive --features serveragainst the pin; #4598 adds the e2e case for the combination above and runs its merge, prove and verify suites against it.Breaking Changes
None.
Checklist
🤖 Generated with Claude Code