fix(dashmate): Remove -masternodeblsprivkey from docker arguments - #538
Merged
Conversation
5 tasks
shumkov
requested changes
Sep 27, 2022
shumkov
requested changes
Sep 28, 2022
shumkov
added a commit
that referenced
this pull request
Sep 30, 2022
pshenmic
added a commit
that referenced
this pull request
Sep 30, 2022
shumkov
added a commit
that referenced
this pull request
Oct 3, 2022
* fix(dashmate): update v18 for the mainnet nodes * feat(dashmate): add reindex command (wip) * chore(dashmate): bump migration version * chore(dashmate): bump migration version * fix(dashmate): start only core nodes during reindex * feat(dashmate): change running core strategy * chore(dashmate): wip * fix(dashmate): fix naming * feat(dashmate): migrate wait job to observer * makes it show the progress in group mode * feat(dashmate): add healthcheck in the waitForCoreSync.js * feat(dashmate): move out upper * docs(dashmate): add reindex documentation * chore(dashmate): lower dashcore * chore(dashmate): code review fix * chore(dashmate): remove outdated const * chore(dashmate): fix * chore(dashmate): migrate to v23-dev * chore(dashmate): migrate to v23-dev * docs(dashmate): fix code review fixes Co-authored-by: thephez <thephez@users.noreply.github.com> * chore(dashmate): update docs Co-authored-by: thephez <thephez@users.noreply.github.com> * fix(dashmate): code review fixes * fix(dashmate): fix typo * fix(dashmate): fix typo * chore(dashmate): remove healthcheck * chore(dashmate): typo fix * chore(dashmate): fix lint * chore(dashmate): fix eslint * chore(dashmate): code review fixes * feat(dashmate): make reindex as a core subscommand * fix(dashmate): Remove -masternodeblsprivkey from docker arguments (#538) * feat(dashmate): check for docker container existence * chore(dashmate): code review text fixes Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> * fix(dashmate): code review fix * chore(dashmate): fix code review * fix(dashmate): reuse container info * chore(dashmate): some minor imprvmnts * chore(dashmate): fix missing semicolon * chore(dashmate): fix linting and some bugs * chore: combine migrations Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Masternode operator privkey is passed to the command arguments when it is started via dashmate. It is not secure, and disables wallet mode when private key is empty (when run as node). Original issue here #87
What was done?
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only