Skip to content

ci: sign MacOs Dashmate release#890

Merged
shuplenkov merged 2 commits into
v0.24-devfrom
macos-signature
Apr 7, 2023
Merged

ci: sign MacOs Dashmate release#890
shuplenkov merged 2 commits into
v0.24-devfrom
macos-signature

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Apr 6, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

Need to sign Dashmate MacOs release package

What was done?

Added signing GitHub action. The signing is doing by Oclif.

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Apr 6, 2023

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit 2ca9a51 into v0.24-dev Apr 7, 2023
@shuplenkov shuplenkov deleted the macos-signature branch April 7, 2023 18:33
markin-io pushed a commit that referenced this pull request Apr 26, 2023
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
QuantumExplorer added a commit that referenced this pull request Jul 14, 2026
…ernode aggregation

Bump rust-dashcore to 38c689d9 (#891, fixes #890): block processing now
stamps each retained record's BlockInfo with its block.vtx index, and
chainlock promotion preserves it.

- provider_masternode_txs_blocking reads block_info.position() instead
  of the previous position = 0 placeholder, so same-block provider
  updates aggregate in Core's apply order.
- The position round-trips persistence: TransactionRecordFFI and
  PersistentTransaction carry block_position/has_block_position, and
  the provider special-tx staging path restores it onto the rebuilt
  record's BlockInfo. Rows persisted before the field existed restore
  as None and fall back to feed order among themselves.
- Round-trip test covers both the flagged and pre-field cases.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants