Skip to content

feat(dashmate): replace js-drive-abci with rs-drive-abci #926

Merged
lklimek merged 8 commits into
feat/abci_validationfrom
feat/dashmate-rs-drive
Apr 19, 2023
Merged

feat(dashmate): replace js-drive-abci with rs-drive-abci #926
lklimek merged 8 commits into
feat/abci_validationfrom
feat/dashmate-rs-drive

Conversation

@lklimek

@lklimek lklimek commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

dashmate should create networks using rs-drive-abci instead of js-drive-abci.

What was done?

  1. Reverted schema URL: from 'https://schema.dash.org/dpp-0-4-0/meta/data-contract#' back to 'http://json-schema.org/draft-07/schema#'
  2. Updated docker compose files for drive_abci to use rs-drive-abci/Dockerfile
  3. Adjusted configuration
  4. Fixed some build issues

How Has This Been Tested?

#! /bin/bash -x

yarn reset --hard

docker rm -f `docker ps -q`
docker volume rm -f `docker volume list -q`
docker network prune -f

rm -rf /home/ubuntu/.dashmate

set -e

scripts/configure_dashmate.sh

yarn setup
yarn start

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek force-pushed the feat/dashmate-rs-drive branch from 49120ab to 77363af Compare April 19, 2023 11:29
Comment thread Cargo.toml
"packages/rs-drive",
"packages/rs-platform-value",
"packages/rs-drive-abci",
"packages/rs-drive-nodejs",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to keep this, after all bindings for node-js are a good thing to have, even if we don't use them in our own project.

@lklimek lklimek marked this pull request as ready for review April 19, 2023 11:54
@lklimek lklimek merged commit ea79546 into feat/abci_validation Apr 19, 2023
@lklimek lklimek deleted the feat/dashmate-rs-drive branch April 19, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants