feat(dashmate): replace js-drive-abci with rs-drive-abci #926
Merged
Conversation
49120ab to
77363af
Compare
QuantumExplorer
approved these changes
Apr 19, 2023
| "packages/rs-drive", | ||
| "packages/rs-platform-value", | ||
| "packages/rs-drive-abci", | ||
| "packages/rs-drive-nodejs", |
Member
There was a problem hiding this comment.
We might want to keep this, after all bindings for node-js are a good thing to have, even if we don't use them in our own project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
dashmate should create networks using rs-drive-abci instead of js-drive-abci.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only